[Backport 2.x] Support editing of certain workflow fields on a provisioned workflow #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…757) * Support editing of certain workflow fields on a provisioned workflow Signed-off-by: Daniel Widdis <[email protected]> * Add integ test Signed-off-by: Daniel Widdis <[email protected]> * Address review comments Signed-off-by: Daniel Widdis <[email protected]> * Refactor field update method to Template class Signed-off-by: Daniel Widdis <[email protected]> * Update tests to ensure update timestamp increments Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit 7d45f92) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
dbwiddis
approved these changes
Jul 10, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #775 +/- ##
============================================
+ Coverage 74.37% 74.61% +0.24%
- Complexity 745 783 +38
============================================
Files 84 84
Lines 3825 3873 +48
Branches 333 356 +23
============================================
+ Hits 2845 2890 +45
Misses 825 825
- Partials 155 158 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 7d45f92 from #757.