Update PULL_REQUEST_TEMPLATE to include an API spec change in the checklist. #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cklist. Signed-off-by: dblock <[email protected]>
dblock
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
22 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #773 +/- ##
============================================
+ Coverage 74.30% 74.37% +0.07%
Complexity 745 745
============================================
Files 84 84
Lines 3825 3825
Branches 333 333
============================================
+ Hits 2842 2845 +3
+ Misses 829 825 -4
- Partials 154 155 +1 ☔ View full report in Codecov by Sentry. |
owaiskazi19
approved these changes
Jul 9, 2024
dbwiddis
approved these changes
Jul 9, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 9, 2024
…cklist. (#773) Signed-off-by: dblock <[email protected]> (cherry picked from commit 910089c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Jul 9, 2024
…ange in the checklist. (#774) Update PULL_REQUEST_TEMPLATE to include an API spec change in the checklist. (#773) (cherry picked from commit 910089c) Signed-off-by: dblock <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming from opensearch-project/opensearch-api-specification#387, update PR template to include a checkbox that requests that all API changes be documented in the OpenAPI spec used to generate clients.