Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch diffCoverage plugin to deltaCoverage #762

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

dbwiddis
Copy link
Member

@dbwiddis dbwiddis commented Jul 6, 2024

Description

Removes the abandonware diffCoverage plugin and replaces it with deltaCoverage.

Issues Resolved

Fixes #761

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Jul 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.37%. Comparing base (dae810c) to head (aa3eb77).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #762   +/-   ##
=========================================
  Coverage     74.37%   74.37%           
  Complexity      745      745           
=========================================
  Files            84       84           
  Lines          3825     3825           
  Branches        333      333           
=========================================
  Hits           2845     2845           
  Misses          825      825           
  Partials        155      155           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amitgalitz
Copy link
Member

Mend security failing here

@dbwiddis
Copy link
Member Author

dbwiddis commented Jul 8, 2024

Mend security failing here

It's been flaky for the past several days across multiple repos... something about its token. Retrying usually works.

@owaiskazi19
Copy link
Member

Is this something we are changing in core as well? We were using diffCoverage to be same across all the repos under opensearch-project

@dbwiddis
Copy link
Member Author

dbwiddis commented Jul 8, 2024

Is this something we are changing in core as well? We were using diffCoverage to be same across all the repos under opensearch-project

That's codecov that you're thinking of. That won't change, we'll still get the PR comments with the coverage diff, see #763 (comment)

This is a local command you can type, that's only implemented in our plugin and the Extensions SDK, that the maintainer abandoned, and which doesn't support JDK21. Someone's moved forward with a fork of that.

So I can locally run ./gradlew test deltaCoverage before even submitting a PR, and get a html report that looks like this:
image

The details match CodeCov exactly.

@dbwiddis dbwiddis merged commit a0a9375 into opensearch-project:main Jul 8, 2024
20 checks passed
@dbwiddis dbwiddis deleted the delta-coverage branch July 8, 2024 20:32
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 8, 2024
* Switch diffCoverage plugin to deltaCoverage

Signed-off-by: Daniel Widdis <[email protected]>

* Allow lower NodeJS version on GH runners for security test

Signed-off-by: Daniel Widdis <[email protected]>

---------

Signed-off-by: Daniel Widdis <[email protected]>
(cherry picked from commit a0a9375)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis pushed a commit that referenced this pull request Jul 8, 2024
* Switch diffCoverage plugin to deltaCoverage

Signed-off-by: Daniel Widdis <[email protected]>

* Allow lower NodeJS version on GH runners for security test

Signed-off-by: Daniel Widdis <[email protected]>

---------

Signed-off-by: Daniel Widdis <[email protected]>
(cherry picked from commit a0a9375)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis added a commit that referenced this pull request Jul 8, 2024
* Switch diffCoverage plugin to deltaCoverage (#762)

* Switch diffCoverage plugin to deltaCoverage

Signed-off-by: Daniel Widdis <[email protected]>

* Allow lower NodeJS version on GH runners for security test

Signed-off-by: Daniel Widdis <[email protected]>

---------

Signed-off-by: Daniel Widdis <[email protected]>
(cherry picked from commit a0a9375)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Update build.gradle

Signed-off-by: Daniel Widdis <[email protected]>

---------

Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Daniel Widdis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport PRs to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] DiffCoverage Gradle plugin is not JDK21 compatibile
3 participants