Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop duplicate CI runs on branch push by bots #755

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

dbwiddis
Copy link
Member

@dbwiddis dbwiddis commented Jul 3, 2024

Description

CI tests are running twice on version-bump PRs
BWC tests are running twice on version-bump and dependency bump and backport PRs

These are caused because bots push to a branch on the repo in addition to the PRs.

Unfortunately, push is the only way to run a workflow when it is rebased (without changing the PR commits):

  • For dependency version updates, there's a check-box in the PR description to rebase that will generate a new latest commit
  • For backport and version bump PRs, added the workflow-dispatch trigger to enable manually rerunning the workflows on the appropriate branch. This is particularly useful when a version bump is past the 30-day retry window.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.37%. Comparing base (c76fb3a) to head (c7d7121).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #755   +/-   ##
=========================================
  Coverage     74.37%   74.37%           
  Complexity      745      745           
=========================================
  Files            84       84           
  Lines          3825     3825           
  Branches        333      333           
=========================================
  Hits           2845     2845           
  Misses          825      825           
  Partials        155      155           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbwiddis dbwiddis force-pushed the dupe-ci-bot branch 2 times, most recently from cb4d6ab to 89cd5c4 Compare July 4, 2024 19:46
@dbwiddis dbwiddis merged commit 9f83d94 into opensearch-project:main Jul 16, 2024
20 checks passed
@dbwiddis dbwiddis deleted the dupe-ci-bot branch July 16, 2024 16:06
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 16, 2024
Signed-off-by: Daniel Widdis <[email protected]>
(cherry picked from commit 9f83d94)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis pushed a commit that referenced this pull request Jul 16, 2024
Stop duplicate CI runs on branch push by bots (#755)


(cherry picked from commit 9f83d94)

Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport PRs to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants