[Backport 2.x] Delete workflow state when template is deleted and no resources exist #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…#689) * Add test for updating state index Signed-off-by: Daniel Widdis <[email protected]> * Add method to delete state document to FlowFrameworkIndidesHandler Signed-off-by: Daniel Widdis <[email protected]> * Delete state document on deprovision if no template exists Signed-off-by: Daniel Widdis <[email protected]> * Add check whether state can be deleted to FlowFrameworkIndicesHandler Signed-off-by: Daniel Widdis <[email protected]> * Conditionally delete state when deleting template Signed-off-by: Daniel Widdis <[email protected]> * Add IT to test workflow state deletion on deprovision/no-resources Signed-off-by: Daniel Widdis <[email protected]> * Fix typo Signed-off-by: Daniel Widdis <[email protected]> * Properly test ResponseException on Workflow State 404 Signed-off-by: Daniel Widdis <[email protected]> * Fetch workflowId of newly created template Signed-off-by: Daniel Widdis <[email protected]> * Stabilize IT Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit ff072de) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
dbwiddis
approved these changes
Apr 30, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #694 +/- ##
============================================
+ Coverage 72.64% 73.78% +1.13%
- Complexity 697 722 +25
============================================
Files 82 82
Lines 3605 3662 +57
Branches 309 312 +3
============================================
+ Hits 2619 2702 +83
+ Misses 841 818 -23
+ Partials 145 142 -3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport ff072de from #689.