Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport-2.x] Use jsonB instead of jackson (#586) #645

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

owaiskazi19
Copy link
Member

@owaiskazi19 owaiskazi19 commented Apr 4, 2024

  • Use jsonB instead of jackson

  • Resolve Jar Hell with newest versions and jakarta dependencies


Description

Backport of #586

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Use jsonB instead of jackson

Signed-off-by: Owais Kazi <[email protected]>

* Resolve Jar Hell with newest versions and jakarta dependencies

Signed-off-by: Daniel Widdis <[email protected]>

---------

Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Co-authored-by: Daniel Widdis <[email protected]>
Signed-off-by: owaiskazi19 <[email protected]>
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.33%. Comparing base (c71020a) to head (2fc7371).

Additional details and impacted files
@@            Coverage Diff            @@
##                2.x     #645   +/-   ##
=========================================
  Coverage     72.33%   72.33%           
  Complexity      680      680           
=========================================
  Files            82       82           
  Lines          3528     3528           
  Branches        284      284           
=========================================
  Hits           2552     2552           
  Misses          850      850           
  Partials        126      126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was just going to request changes on http but you fixed it first :)

@dbwiddis dbwiddis merged commit c60836f into opensearch-project:2.x Apr 4, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants