-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[POC] Adding Orchestrate API and Search Response Processor Step #619
Merged
amitgalitz
merged 8 commits into
opensearch-project:feature-poc
from
joshpalis:orchestrate
Apr 1, 2024
Merged
[POC] Adding Orchestrate API and Search Response Processor Step #619
amitgalitz
merged 8 commits into
opensearch-project:feature-poc
from
joshpalis:orchestrate
Apr 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshpalis
requested review from
dbwiddis,
owaiskazi19,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
March 26, 2024 23:21
Tests will fail since since the getters for the request and response processor factories are package private :
Modifying this line in the |
owaiskazi19
reviewed
Mar 27, 2024
src/main/java/org/opensearch/flowframework/workflow/SearchResponseProcessorStep.java
Show resolved
Hide resolved
owaiskazi19
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Joshua Palis <[email protected]>
…onse processor step Signed-off-by: Joshua Palis <[email protected]>
Signed-off-by: Joshua Palis <[email protected]>
Signed-off-by: Joshua Palis <[email protected]>
Signed-off-by: Joshua Palis <[email protected]>
Signed-off-by: Joshua Palis <[email protected]>
Signed-off-by: Joshua Palis <[email protected]>
Signed-off-by: Joshua Palis <[email protected]>
amitgalitz
approved these changes
Apr 1, 2024
amitgalitz
merged commit Apr 1, 2024
a08cdbc
into
opensearch-project:feature-poc
8 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new
/_plugins/_flow_framework/<workflow_id>/_orchestrate
API which accepts a map of string to string as the request body content.Example payload looks like :
The transport action retrieves this along with the workflow ID to fetch a previously created
search
use case template from the global context index. The process nodes are then created, passing in the request body content map for substitution and then executes the graph.Upon attempting to complete each plain action future, we track the final returned search response to return to the user
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.