Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] Adding Orchestrate API and Search Response Processor Step #619

Merged
merged 8 commits into from
Apr 1, 2024

Conversation

joshpalis
Copy link
Member

@joshpalis joshpalis commented Mar 26, 2024

Description

Adds a new /_plugins/_flow_framework/<workflow_id>/_orchestrate API which accepts a map of string to string as the request body content.

Example payload looks like :

POST _plugins/_flow_framework/<workflow_id>/_orchestrate 
{
    "model_id" : "uuihhqw0f9i90932r1h0a9w0f"
}

The transport action retrieves this along with the workflow ID to fetch a previously created search use case template from the global context index. The process nodes are then created, passing in the request body content map for substitution and then executes the graph.

Upon attempting to complete each plain action future, we track the final returned search response to return to the user

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@joshpalis
Copy link
Member Author

Tests will fail since since the getters for the request and response processor factories are package private :

> Task :compileJava
/__w/flow-framework/flow-framework/src/main/java/org/opensearch/flowframework/workflow/SearchResponseProcessorStep.java:85: error: getResponseProcessorFactories() is not public in SearchPipelineService; cannot be accessed from outside package
                .getResponseProcessorFactories();
                ^

Modifying this line in the SearchPipelineService so that the getter is public and publishing to maven local will allow the tests to pass locally

Copy link
Member

@owaiskazi19 owaiskazi19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Joshua Palis <[email protected]>
Signed-off-by: Joshua Palis <[email protected]>
@amitgalitz amitgalitz merged commit a08cdbc into opensearch-project:feature-poc Apr 1, 2024
8 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants