[Backport 2.x] Adds Create Ingest Pipeline Step #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Initial create ingest pipeline implementation Signed-off-by: Joshua Palis <[email protected]> * Adding TODOs for storing response to global context index, fixing comments Signed-off-by: Joshua Palis <[email protected]> * Updating workflowData interface, modifying CreateIngestPipelineStep Signed-off-by: Joshua Palis <[email protected]> * updating workflow data extraction to read pipelineId from parameters rather than from content Signed-off-by: Joshua Palis <[email protected]> * removing unecessary cast Signed-off-by: Joshua Palis <[email protected]> * Pulls all required data from content rather than from params, fixes javadoc error Signed-off-by: Joshua Palis <[email protected]> * fixing comments Signed-off-by: Joshua Palis <[email protected]> * addressing PR comments, adding switch statement to handle parsing workflow data for required fields Signed-off-by: Joshua Palis <[email protected]> * Adding entry import Signed-off-by: Joshua Palis <[email protected]> * fixing comments Signed-off-by: Joshua Palis <[email protected]> * Adds unit tests for create ingest pipeline step, fixes pipeline request body generator Signed-off-by: Joshua Palis <[email protected]> * Adding failure tests Signed-off-by: Joshua Palis <[email protected]> * Addressing PR comments Signed-off-by: Joshua Palis <[email protected]> * Addressing PR comments Signed-off-by: Joshua Palis <[email protected]> * Fixing workflow data Signed-off-by: Joshua Palis <[email protected]> --------- Signed-off-by: Joshua Palis <[email protected]> (cherry picked from commit 1d22bee) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov Report
@@ Coverage Diff @@
## 2.x #59 +/- ##
============================================
+ Coverage 68.33% 73.87% +5.54%
- Complexity 48 65 +17
============================================
Files 7 8 +1
Lines 180 245 +65
Branches 18 22 +4
============================================
+ Hits 123 181 +58
- Misses 48 54 +6
- Partials 9 10 +1
|
joshpalis
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1d22bee from #44.