Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport feature/agent_framework] Adds transport request retry capability for GetMLTaskStep #205

Merged
merged 1 commit into from
Nov 28, 2023
Merged

[Backport feature/agent_framework] Adds transport request retry capability for GetMLTaskStep #205

merged 1 commit into from
Nov 28, 2023

Commits on Nov 28, 2023

  1. Adds transport request retry capability for GetMLTaskStep (#179) 

    * Added FlowFrameworkMaxRequestRetrySetting and applied this to GetMlTaskStep

Signed-off-by: Joshua Palis <[email protected]>

* Addressing PR comments, creating abstract class RetryableWorkflowStep to initialize the setting update consumer for max retry request setting, passing settings and clusterservice to retryable workflow step instead

Signed-off-by: Joshua Palis <[email protected]>

* Addressing PR comments

Signed-off-by: Joshua Palis <[email protected]>

* Removing retry utils class

Signed-off-by: Joshua Palis <[email protected]>

* Fixing failure unit tests to ensure thread sleep isnt invoked

Signed-off-by: Joshua Palis <[email protected]>

* Addressing PR comments, changing setting name, improving javadoc, removing max value from setting, cancelling future on thread interuppt

Signed-off-by: Joshua Palis <[email protected]>

---------

Signed-off-by: Joshua Palis <[email protected]>
(cherry picked from commit 1092325)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
    @github-actions
    github-actions[bot] committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    2684fd2 View commit details
    Browse the repository at this point in the history