Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore git diff errors when there's no origin branch #167

Closed
wants to merge 1 commit into from
Closed

Ignore git diff errors when there's no origin branch #167

wants to merge 1 commit into from

Conversation

dbwiddis
Copy link
Member

Description

The git diff command used for local code coverage reports fails when there is no origin to diff against. This ignores the return value which may occur on build environments.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (56ccb1d) 68.39% compared to head (46d9cd4) 71.12%.
Report is 3 commits behind head on main.

Files Patch % Lines
...flowframework/workflow/RegisterLocalModelStep.java 91.13% 4 Missing and 3 partials ⚠️
...a/org/opensearch/flowframework/model/Template.java 92.15% 3 Missing and 1 partial ⚠️
...lowframework/workflow/RegisterRemoteModelStep.java 86.95% 1 Missing and 2 partials ⚠️
...ensearch/flowframework/workflow/GetMLTaskStep.java 92.85% 1 Missing and 1 partial ⚠️
...framework/indices/FlowFrameworkIndicesHandler.java 0.00% 1 Missing ⚠️
.../opensearch/flowframework/model/WorkflowState.java 0.00% 1 Missing ⚠️
...pensearch/flowframework/util/RestHandlerUtils.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #167      +/-   ##
============================================
+ Coverage     68.39%   71.12%   +2.73%     
- Complexity      339      368      +29     
============================================
  Files            45       47       +2     
  Lines          1585     1728     +143     
  Branches        143      154      +11     
============================================
+ Hits           1084     1229     +145     
+ Misses          452      443       -9     
- Partials         49       56       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbwiddis
Copy link
Member Author

Closing in favor of #166

@dbwiddis dbwiddis closed this Nov 14, 2023
@dbwiddis dbwiddis deleted the gitdiff branch November 14, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport PRs to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants