Fix Create Connector actions parsing #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Signed-off-by: Daniel Widdis <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #127 +/- ##
============================================
+ Coverage 66.05% 66.71% +0.66%
- Complexity 266 272 +6
============================================
Files 34 34
Lines 1299 1322 +23
Branches 123 125 +2
============================================
+ Hits 858 882 +24
+ Misses 399 395 -4
- Partials 42 45 +3
|
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
commented
Oct 31, 2023
src/test/java/org/opensearch/flowframework/workflow/CreateConnectorStepTests.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Daniel Widdis <[email protected]>
owaiskazi19
approved these changes
Oct 31, 2023
joshpalis
approved these changes
Oct 31, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
* Fix Create Connector actions parsing Signed-off-by: Daniel Widdis <[email protected]> * Fix tests Signed-off-by: Daniel Widdis <[email protected]> * Handle exceptions Signed-off-by: Daniel Widdis <[email protected]> * Fix parameter key in tests Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit 8e85f98) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Oct 31, 2023
Fix Create Connector actions parsing (#127) * Fix Create Connector actions parsing * Fix tests * Handle exceptions * Fix parameter key in tests --------- (cherry picked from commit 8e85f98) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Properly parses the actions in a Create Connector step
Issues Resolved
Fixes #123
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.