Added register a group model step #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owais Kazi <[email protected]>
owaiskazi19
requested review from
dbwiddis,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
owaiskazi19
changed the title
amitgalitz
reviewed
Oct 26, 2023
amitgalitz
reviewed
Oct 26, 2023
src/main/java/org/opensearch/flowframework/workflow/ModelGroupStep.java
Outdated
Show resolved
Hide resolved
amitgalitz
reviewed
Oct 26, 2023
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
joshpalis
approved these changes
Oct 27, 2023
Signed-off-by: Owais Kazi <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #118 +/- ##
============================================
+ Coverage 80.24% 80.68% +0.44%
- Complexity 250 261 +11
============================================
Files 30 31 +1
Lines 992 1046 +54
Branches 95 103 +8
============================================
+ Hits 796 844 +48
- Misses 160 161 +1
- Partials 36 41 +5
|
dbwiddis
reviewed
Oct 27, 2023
src/main/java/org/opensearch/flowframework/workflow/ModelGroupStep.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/ModelGroupStep.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/flowframework/workflow/CreateConnectorStepTests.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/ModelGroupStep.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/flowframework/workflow/ModelGroupStepTests.java
Show resolved
Hide resolved
src/test/java/org/opensearch/flowframework/workflow/ModelGroupStepTests.java
Show resolved
Hide resolved
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
owaiskazi19
force-pushed
the
model-group
branch
from
cc74a45
to
fef826e
Compare
amitgalitz
reviewed
Oct 30, 2023
amitgalitz
reviewed
Oct 30, 2023
dbwiddis
approved these changes
Oct 30, 2023
|
LGTM to merge. @amitgalitz can you resolve any conversations you still have open? |
amitgalitz
approved these changes
Oct 30, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 30, 2023
* Added Registering a group model Signed-off-by: Owais Kazi <[email protected]> * Updated create connector test Signed-off-by: Owais Kazi <[email protected]> * Added optional field and handled them for creating the builder Signed-off-by: Owais Kazi <[email protected]> * Added another test for name check Signed-off-by: Owais Kazi <[email protected]> * Addressed PR comments Signed-off-by: Owais Kazi <[email protected]> * Moved common fields to CommonValue Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]> (cherry picked from commit bcd53e1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
owaiskazi19
pushed a commit
that referenced
this pull request
Oct 30, 2023
Added register a group model step (#118) * Added Registering a group model * Updated create connector test * Added optional field and handled them for creating the builder * Added another test for name check * Addressed PR comments * Moved common fields to CommonValue --------- (cherry picked from commit bcd53e1) Signed-off-by: Owais Kazi <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added Registering a group model
Issues Resolved
Fixes #83
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.