Reordered imports to match with OpenSearch #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owais Kazi <[email protected]>
owaiskazi19
requested review from
dbwiddis,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov Report
@@ Coverage Diff @@
## main #11 +/- ##
======================================
Coverage ? 0.00%
======================================
Files ? 1
Lines ? 1
Branches ? 0
======================================
Hits ? 0
Misses ? 1
Partials ? 0 |
dbwiddis
approved these changes
Aug 21, 2023
|
LGTM, but just a curiosity question - are we manually rearranging the import order here? Maybe we can use gradle format command to do the formatting job? |
@jackiehanyang we've aligned around spotless as our formatting tool. Its main advantage is that it tells you what's wrong in our CI automatically and how to fix it. |
jackiehanyang
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reordered imports to match with OpenSearch as done here: opensearch-project/OpenSearch#9306
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.