Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breadcrumbs/excluding collection index pages from parent relationship #7758

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

kolchfa-aws
Copy link
Collaborator

Closes #6935

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@hdhalter
Copy link
Contributor

Thanks, @kolchfa-aws! I tested it, and it fixes the second-level breadcrumbs. At some point we should fix the jekyll template so that the top level topic appears, but this is good for now.

@kolchfa-aws
Copy link
Collaborator Author

@hdhalter This is the default behavior of our current template. You can put in a feature request for the template change so we have this task on our radar.

@kolchfa-aws kolchfa-aws merged commit d8f1b7b into main Jul 17, 2024
7 checks passed
@opensearch-trigger-bot
Copy link

The backport to 2.15 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.15 2.15
# Navigate to the new working tree
pushd ../.worktrees/backport-2.15
# Create a new branch
git switch --create backport/backport-7758-to-2.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d8f1b7b95d3d90f130b6b590ee7526ca0c8a186a
# Push it to GitHub
git push --set-upstream origin backport/backport-7758-to-2.15
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.15

Then, create a pull request where the base branch is 2.15 and the compare/head branch is backport/backport-7758-to-2.15.

@opensearch-trigger-bot
Copy link

The backport to 2.15 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.15 2.15
# Navigate to the new working tree
pushd ../.worktrees/backport-2.15
# Create a new branch
git switch --create backport/backport-7758-to-2.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d8f1b7b95d3d90f130b6b590ee7526ca0c8a186a
# Push it to GitHub
git push --set-upstream origin backport/backport-7758-to-2.15
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.15

Then, create a pull request where the base branch is 2.15 and the compare/head branch is backport/backport-7758-to-2.15.

leanneeliatra pushed a commit to leanneeliatra/opensearch-documentation-website-forl that referenced this pull request Jul 24, 2024
sandervandegeijn pushed a commit to sandervandegeijn/documentation-website that referenced this pull request Jul 30, 2024
@kolchfa-aws kolchfa-aws deleted the breadcrumb-fix branch August 15, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Hierarchical breadcrumb links to the wrong place
2 participants