-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document optional clear_status query parameter for Delete Workflow API #7268
Document optional clear_status query parameter for Delete Workflow API #7268
Conversation
4121b42
to
0151f6b
Compare
@dbwiddis - Is this ready for review by the doc team? |
Yep! Ship it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @dbwiddis! A couple of comments/suggestions that should be quick to resolve.
For my future reference, is there something else I should do after tech review to make this more obvious? Can I change the labels myself or do some other automation-thingie to say tech is done? |
@dbwiddis I don't know if you have the ability to add the label but that's what we do on the doc team to indicate the status of the PR. You can just comment on the PR once all tech reviews are done, and we'll move it to doc review and then editorial review. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dbwiddis @kolchfa-aws Just one minor change. Thanks!
|
||
Note that deleting a workflow only deletes the stored template but does not deprovision its resources. | ||
Note that deleting a workflow only deletes the stored template but does not deprovision its resources. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that deleting a workflow only deletes the stored template but does not deprovision its resources. | |
Note that deleting a workflow only deletes the stored template---it does not deprovision its resources. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed... confirming three (3) hyphens is intended here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 hyphens is a Markdown way to specify an em dash 😄
Signed-off-by: Daniel Widdis <[email protected]>
Co-authored-by: Owais Kazi <[email protected]> Signed-off-by: Daniel Widdis <[email protected]>
Co-authored-by: Owais Kazi <[email protected]> Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
3a30e71
to
ef5da97
Compare
Description
opensearch-project/flow-framework#719 adds a
clear_status
parameter to the Delete Workflow API to also delete the corresponding workflow state document.Targeted for 2.15 release.
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.