Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation to provide notice about deprecation of security tools in the next major release #3463

Closed
wants to merge 5 commits into from

Conversation

cwillum
Copy link
Contributor

@cwillum cwillum commented Mar 15, 2023

Description

The audit_config_migrater, hash, and securityadmin security tools will be deprecated in the next major release. This documentation alerts users to their imminent replacement.

Issues Resolved

Added an important banner note including the news of this deprecation in relevant places in documentation.

Fixes #503

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cwillum cwillum added v3.0.0 2 - In progress Issue/PR: The issue or PR is in progress. security Sev2 High-medium priority. Upcoming release or incorrect information. labels Mar 15, 2023
@cwillum cwillum requested a review from a team as a code owner March 15, 2023 22:19
@cwillum cwillum self-assigned this Mar 15, 2023
@cwillum
Copy link
Contributor Author

cwillum commented Mar 16, 2023

@peternied I searched through the documentation website for instances where any of the four tools appear: install_demo_configuration, audit_config_migrater, hash, and securityadmin. Most surprising of all was not finding any mention of install_demo_configuration. Is this possibly an oversight in documentation?
In any case, I've added deprecation banner notes for hash and securityadmin wherever they appear as a first instance in relevant documentation. We can change or add to the wording. Could you have a look at the statements as they are currently? Thanks.

@cwillum
Copy link
Contributor Author

cwillum commented Mar 30, 2023

@opensearch-project/security Hi team, when you have a chance, could someone look at these deprecation flags I've added to documentation to alert users that securityadmin and hash tools will be replaced in the next major version. Related to issue #1756. Thanks.

@cwillum
Copy link
Contributor Author

cwillum commented Mar 31, 2023

@peternied @RyanL1997 Thanks for the reviews. Will move this along. One thing I forgot to ask about. I believe we'll want to backport this flag/alert through all minor versions of 2.x documentation and include 1.3. Can you confirm whether this is correct?

@cwillum cwillum added 4 - Doc review PR: Doc review in progress and removed 2 - In progress Issue/PR: The issue or PR is in progress. labels Mar 31, 2023
@peternied
Copy link
Member

we'll want to backport this flag/alert through all minor versions of 2.x documentation and include 1.3.

Good idea @cwillum yes we should backport these documentation to all versions

@cwillum cwillum added backport 1.3 PR: Backport label for v1.3.x backport 2.0 PR: Backport label for v2.0.x backport 2.1 PR: Backport label for 2.1 backport 2.2 PR: Backport label for 2.2 backport 2.3 PR: Backport label for 2.3 backport 2.4 PR: Backport label for 2.4 backport 2.5 PR: Backport label for 2.5 backport 2.6 PR: Backport label for 2.6 labels Apr 3, 2023
@cwperks
Copy link
Member

cwperks commented Apr 3, 2023

@cwillum @peternied Judging by the number of reactions on this comment: opensearch-project/security#1755 (comment) - the deprecation is definitely a controversial matter for these tools. Absent of a clear replacement in the next major version, I am at the moment more in favor of removing the deprecation notices on the tools. Long-term the OpenSearch project would like Security to move into the core of OpenSearch, but its not clear if that would be delivered by 3.0.0 or a future major version.

@cwillum
Copy link
Contributor Author

cwillum commented Apr 3, 2023

@peternied @cwperks @RyanL1997 Thanks for the responses here. I'm going to put this on simmer for the moment. If over the next week some message more appropriate comes to mind, I could change the language and put this back in progress. Otherwise, I could close this one and leave the idea alone for the time being. If an alternative to these tools has a chance of appearing in 3.x with a full deprecation by version 4, it might be more appropriate to add the alert after version 3 releases. I'll stay in contact on the issue.

@cwillum cwillum removed the 4 - Doc review PR: Doc review in progress label Apr 3, 2023
@cwillum cwillum added feedback needed and removed Sev2 High-medium priority. Upcoming release or incorrect information. labels Apr 3, 2023
@cwillum cwillum marked this pull request as draft April 3, 2023 17:04
@davidlago
Copy link

I second @cwperks's comment... I think in hindsight we jumped on the deprecation bandwagon too quickly, or at least at the time it seemed like a replacement would definitely be in place by 3.0. I don't think we are investing in that replacement at this time, and with the potential of an external factor forcing our hand (for example, a Lucene version bump), I think it is more likely than not that this is a 4.0 thing rather than 3.0.

I don't think there is anything wrong with deprecation notices lasting more than just one major version bump, but we should perhaps hold off on giving this even more visibility until we have a more clear picture of what a replacement looks like and some sort of timeline.

@cwillum
Copy link
Contributor Author

cwillum commented Apr 11, 2023

@davidlago This makes sense. I'm closing this PR. We can open a new one when the circumstances are right and we have a better picture of a replacement.

@cwillum cwillum closed this Apr 11, 2023
@hdhalter hdhalter deleted the fix#503-sec-tool-deprecate branch March 28, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.3 PR: Backport label for v1.3.x backport 2.0 PR: Backport label for v2.0.x backport 2.1 PR: Backport label for 2.1 backport 2.2 PR: Backport label for 2.2 backport 2.3 PR: Backport label for 2.3 backport 2.4 PR: Backport label for 2.4 backport 2.5 PR: Backport label for 2.5 backport 2.6 PR: Backport label for 2.6 feedback needed security v3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add deprecation notices for Security Plugin tools
5 participants