Escape control characters for DynamoDB source #5177
+16
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Sasieta Arana <[email protected]>
paulsasi
requested review from
sb2k16,
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
paulsasi
changed the title
dlvenable
requested changes
Nov 12, 2024
| char c = jsonData.charAt(i); | ||
| if (Character.isISOControl(c) && c != '\t' && c != '\n' && c != '\r') { | ||
| // Replace control characters with escaped versions (e.g. \u0000 for null, \u0001 for start of heading, etc.) | ||
| sanitizedStringBuilder.append(String.format("\\u%04X", (int) c)); |
There was a problem hiding this comment.
Is there a way to write this string without calling String.format to avoid the performance penalty?
| StringBuilder sanitizedStringBuilder = new StringBuilder(); | ||
| for (int i = 0; i < jsonData.length(); i++) { | ||
| char c = jsonData.charAt(i); | ||
| if (Character.isISOControl(c) && c != '\t' && c != '\n' && c != '\r') { |
There was a problem hiding this comment.
I tend to think that we should have this as an optional configuration to avoid breaking any existing behavior. Thoughts?
dlvenable
requested changes
Nov 12, 2024
| @@ -188,7 +188,8 @@ void test_writeSingleRecordToBuffer() throws Exception { | |||
| "and/or", | |||
| "c:\\Home", | |||
| "I take\nup multiple\nlines", | |||
| "String with some \"backquotes\"." | |||
| "String with some \"backquotes\".", | |||
| "String with some control characters: \0\1\2\3\4\5\6\7\10\11\12\13\14\15\16\17\20\21\22\23\24\25\26\27\28\29\30\31\127\b\t\n\f\r" | |||
There was a problem hiding this comment.
We should also have a test that provides both the input and the expected output to verify that the result is what we want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Escapes control characters for the DynamoDB source.
Issues Resolved
Resolves #5027
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.