Add integration test for Kinesis source #4967
Conversation
sb2k16
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
|
|
||
| when(pipelineDescription.getPipelineName()).thenReturn(PIPELINE_NAME); | ||
|
|
||
| String workerId = "worker-identifier-" + testId; |
There was a problem hiding this comment.
Thanks @chenqi0805! I will address this.
|
|
||
| @BeforeEach | ||
| void setup() { | ||
| this.acknowledgementSetManager = mock(AcknowledgementSetManager.class); |
There was a problem hiding this comment.
You might consider MockitoAnnotations.openMocks(this) for initializing mocked instances
There was a problem hiding this comment.
Thanks @chenqi0805! I will address this.
Signed-off-by: Souvik Bose <[email protected]>
sb2k16
force-pushed
the
kinesis-add-IT
branch
from
598e4a2
to
c2ae582
Compare
There was a problem hiding this comment.
Looks good.
Can you add a readme on how to run the integration tests? Similar to: https://github.com/opensearch-project/data-prepper/blob/main/data-prepper-plugins/s3-sink/README.md#developer-guide
| } | ||
|
|
||
| /** | ||
| * CDK stack that creates a Kinesis stream |
There was a problem hiding this comment.
Is this stack supposed to create a Kinesis stream or not? I only see IAM policies being created.
There was a problem hiding this comment.
The stream will be created as part of the test. The stack only adds the relevant permissions for accessing Kinesis streams and accessing the dynamoDb table for lease coordination.
There was a problem hiding this comment.
Will do a separate PR for adding the README.
Signed-off-by: Souvik Bose <[email protected]>
Description
This PR is to add an integration test for Kinesis source. As part of the integration test, it will perform the following actions:
putRecordAPIIssues Resolved
Resolves #[1082]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.