Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add include_keys and exclude_keys to S3 sink #3122

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

daixba
Copy link
Contributor

@daixba daixba commented Aug 9, 2023

Description

Add include_keys and exclude_keys to S3 sink

Issues Resolved

#3080

Check List

  • New functionality includes testing.
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dlvenable
Copy link
Member

We can ignore the security check in this PR. This PR doesn't modify any build.gradle files. So the source branch is possibly out-of-date, or these exist in main.

@kkondaka
Copy link
Collaborator

kkondaka commented Aug 9, 2023

How do we make sure both codec and sink do not handle tagsTargetKey or exclude_keys or include_keys? Only one of them should do it. If codec is present, it should do it. If it's not present Sink should do it. How do we enforce this?

@dlvenable dlvenable merged commit 94d7b10 into opensearch-project:main Aug 9, 2023
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants