Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: missing request index #3058

Merged
merged 1 commit into from
Jul 25, 2023
Merged

FIX: missing request index #3058

merged 1 commit into from
Jul 25, 2023

Conversation

chenqi0805
Copy link
Collaborator

Description

This fix is a follow up of #3045 . It tackles the generic missing index in bulk request by extracting index value from the first bulk operation.

Bug

2023-07-24T16:51:57,655 [log-pipeline-sink-worker-2-thread-1] WARN  org.opensearch.dataprepper.plugins.sink.opensearch.OpenSearchSink - Document [FailedDlqData{index='test-bulk', indexId='null', status='0', message='Bulk request index cannot be missing', document={log=test log, @timestamp=2023-07-24T16:51:36.582-05:00}}] has failure. DLQ not configured
java.lang.IllegalArgumentException: Bulk request index cannot be missing

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: George Chen <[email protected]>
@github-actions
Copy link

github-actions bot commented Jul 25, 2023

Unit Test Results

  1 276 files  ±0    1 276 suites  ±0   41m 3s ⏱️ -32s
  5 096 tests +3    5 095 ✔️ +3  1 💤 ±0  0 ±0 
10 216 runs  +6  10 214 ✔️ +6  2 💤 ±0  0 ±0 

Results for commit f5c08cb. ± Comparison against base commit 07f00c2.

♻️ This comment has been updated with latest results.

Copy link
Member

@dlvenable dlvenable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chenqi0805 chenqi0805 merged commit 7af9055 into main Jul 25, 2023
60 checks passed
@chenqi0805 chenqi0805 deleted the fix/missing-request-index branch July 25, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants