Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Auth/NoAuth with/without Encryption in Kafka with integration tests #3042

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

kkondaka
Copy link
Collaborator

Add Support for Auth/NoAuth with/without Encryption in Kafka with integration tests

Description

The following authentication and encryption combinations are supported. Integration Tests are added to test all 4 combinations

  1. No Auth, No Encryption (default Kafka)
  2. Username/Password Auth, No Encryption
  3. No Auth, with Encryption enabled
  4. Username/Password Auth, with Encryption enabled.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • [X ] New functionality includes testing.
  • [ X] New functionality has been documented.
    • New functionality has javadoc added
  • [ X] Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some empty methods in this class, will they be implemented later?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is purely for supporting insecure mode. They don't need to be implemented.

@kkondaka kkondaka merged commit b003b08 into opensearch-project:main Jul 20, 2023
24 checks passed
chenqi0805 pushed a commit that referenced this pull request Jul 25, 2023
…egration tests (#3042)

Signed-off-by: Krishna Kondaka <[email protected]>
Co-authored-by: Krishna Kondaka <[email protected]>
@kkondaka kkondaka deleted the kafka-auth-types branch May 13, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants