GitHub-issue#253 : Implemented GeoIP Plugin Configuration Code JUnit … #2909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test cases Signed-off-by: venkataraopasyavula <[email protected]>
venkataraopasyavula
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
cmanning09,
asifsmohammed,
dlvenable and
oeyh
as code owners
kkondaka
requested changes
Jun 22, 2023
| @@ -0,0 +1,3 @@ | |||
| # To enable mocking of final classes with vanilla Mockito | |||
There was a problem hiding this comment.
"mock-maker-inline" is required to mock the final classes. For example AWS "Region" class is final class.
kkondaka
approved these changes
Jun 22, 2023
JonahCalvo
approved these changes
Jun 22, 2023
MaGonzalMayedo
pushed a commit
to MaGonzalMayedo/data-prepper
that referenced
this pull request
Jul 25, 2023
…test cases (opensearch-project#2909) Signed-off-by: venkataraopasyavula <[email protected]> Signed-off-by: Marcos Gonzalez Mayedo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented GeoIP Processor plugin JUnit test cases for the Configuration Code
Issues Resolved
GitHub- issue #253
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.