Addressed review comments

Signed-off-by: Krishna Kondaka <[email protected]>
opensearch-project · Jul 11, 2023 · 983e778 · 983e778
1 parent 2935c26
commit 983e778
Showing 1 changed file with 4 additions and 9 deletions.
diff --git a/...ource/src/integrationTest/java/org/opensearch/dataprepper/plugins/source/SqsWorkerIT.java b/...ource/src/integrationTest/java/org/opensearch/dataprepper/plugins/source/SqsWorkerIT.java
@@ -149,7 +149,7 @@ void processSqsMessages_should_return_at_least_one_message(final int numberOfObj
 
     @ParameterizedTest
     @ValueSource(ints = {1})
-    void processSqsMessages_should_return_at_least_one_message_with_acks_with_callback_invoked_after_processS3Object_finishes(final int numberOfObjectsToWrite) throws IOException {
+    void processSqsMessages_should_return_at_least_one_message_with_acks_with_callback_invoked_after_processS3Object_finishes(final int numberOfObjectsToWrite) throws IOException, InterruptedException {
         writeToS3(numberOfObjectsToWrite);
 
         when(s3SourceConfig.getAcknowledgements()).thenReturn(true);
@@ -205,17 +205,15 @@ void processSqsMessages_should_return_at_least_one_message_with_acks_with_callba
             ready.set(true);
             this.notify();
         }
-        try {
-            Thread.sleep(10000);
-        } catch (Exception e){}
+        Thread.sleep(10000);
 
         assertThat(deletedCount, equalTo((double)1.0));
         assertThat(ackCallbackCount, equalTo((double)1.0));
     }
 
     @ParameterizedTest
     @ValueSource(ints = {1})
-    void processSqsMessages_should_return_at_least_one_message_with_acks_with_callback_invoked_before_processS3Object_finishes(final int numberOfObjectsToWrite) throws IOException {
+    void processSqsMessages_should_return_at_least_one_message_with_acks_with_callback_invoked_before_processS3Object_finishes(final int numberOfObjectsToWrite) throws IOException, InterruptedException {
         writeToS3(numberOfObjectsToWrite);
 
         when(s3SourceConfig.getAcknowledgements()).thenReturn(true);
@@ -277,10 +275,7 @@ void processSqsMessages_should_return_at_least_one_message_with_acks_with_callba
         sinkThread.start();
         final int sqsMessagesProcessed = objectUnderTest.processSqsMessages();
 
-        try {
-            Thread.sleep(10000);
-        } catch (Exception e){}
-
+        Thread.sleep(10000);
 
         assertThat(deletedCount, equalTo((double)1.0));
         assertThat(ackCallbackCount, equalTo((double)1.0));