add static final variable for string comparison

Signed-off-by: Kat Shen <[email protected]>
opensearch-project · Jul 5, 2023 · 204817b · 204817b
1 parent 72cc32f
commit 204817b
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/...rc/main/java/org/opensearch/dataprepper/plugins/processor/keyvalue/KeyValueProcessor.java b/...rc/main/java/org/opensearch/dataprepper/plugins/processor/keyvalue/KeyValueProcessor.java
@@ -36,6 +36,9 @@ public class KeyValueProcessor extends AbstractProcessor<Record<Event>, Record<E
     private final Pattern keyValueDelimiterPattern;
     private final Set<String> includeKeysSet = new HashSet<String>();
     private final Set<String> validTransformOptionSet = Set.of("", "lowercase", "uppercase", "capitalize");
+    private final String LOWERCASE_KEY = "lowercase";
+    private final String UPPERCASE_KEY = "uppercase";
+    private final String CAPITALIZE_KEY = "capitalize";
 
     @DataPrepperPluginConstructor
     public KeyValueProcessor(final PluginMetrics pluginMetrics, final KeyValueProcessorConfig keyValueProcessorConfig) {
@@ -182,11 +185,11 @@ public Collection<Record<Event>> doExecute(final Collection<Record<Event>> recor
     }
 
     private String transformKey(String key) {
-        if(keyValueProcessorConfig.getTransformKey().equals("lowercase")) {
+        if(keyValueProcessorConfig.getTransformKey().equals(LOWERCASE_KEY)) {
             key = key.toLowerCase();
-        } else if(keyValueProcessorConfig.getTransformKey().equals("uppercase")) {
+        } else if(keyValueProcessorConfig.getTransformKey().equals(UPPERCASE_KEY)) {
             key = key.substring(0, 1).toUpperCase() + key.substring(1);
-        } else if(keyValueProcessorConfig.getTransformKey().equals("capitalize")) {
+        } else if(keyValueProcessorConfig.getTransformKey().equals(CAPITALIZE_KEY)) {
             key = key.toUpperCase();
         }
         return key;