Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Onboard Stylelint (#229) #300

Merged
merged 1 commit into from
Dec 13, 2023
+18 −12
Merged

[Backport 2.x] Onboard Stylelint (#229) #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions .github/workflows/test-and-build-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@

name: Test and Build Gantt Chart

on: [pull_request, push]

env:
PLUGIN_NAME: gantt-chart-dashboards
OPENSEARCH_VERSION: '2.x'
OPENSEARCH_VERSION: "2.x"
OPENSEARCH_PLUGIN_VERSION: 2.10.0.0

jobs:
Expand Down Expand Up @@ -67,7 +66,6 @@ jobs:
path: ./dashboards-visualizations/OpenSearch-Dashboards/plugins/gantt-chart/build

windows-build:

runs-on: windows-latest
steps:
- name: Checkout Plugin
Expand All @@ -86,8 +84,8 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version-file: './dashboards-visualizations/OpenSearch-Dashboards/.nvmrc'
registry-url: 'https://registry.npmjs.org'
node-version-file: "./dashboards-visualizations/OpenSearch-Dashboards/.nvmrc"
registry-url: "https://registry.npmjs.org"

- name: Install Yarn
# Need to use bash to avoid having a windows/linux specific step
Expand All @@ -109,6 +107,11 @@ jobs:
cd ./dashboards-visualizations/OpenSearch-Dashboards/plugins/gantt-chart
yarn osd bootstrap
- name: Run Stylelint
run: |
cd ./dashboards-visualizations/OpenSearch-Dashboards/plugins/gantt-chart
yarn lint:style
- name: Test
run: |
cd ./dashboards-visualizations/OpenSearch-Dashboards/plugins/gantt-chart
Expand All @@ -125,9 +128,8 @@ jobs:
with:
name: gantt-chart-windows
path: ./dashboards-visualizations/OpenSearch-Dashboards/plugins/gantt-chart/build

macos-build:

macos-build:
runs-on: macos-latest

steps:
Expand All @@ -144,8 +146,8 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version-file: './dashboards-visualizations/OpenSearch-Dashboards/.nvmrc'
registry-url: 'https://registry.npmjs.org'
node-version-file: "./dashboards-visualizations/OpenSearch-Dashboards/.nvmrc"
registry-url: "https://registry.npmjs.org"

- name: Install Yarn
# Need to use bash to avoid having a windows/linux specific step
Expand All @@ -167,6 +169,11 @@ jobs:
cd ./dashboards-visualizations/OpenSearch-Dashboards/plugins/gantt-chart
yarn osd bootstrap
- name: Run Stylelint
run: |
cd ./dashboards-visualizations/OpenSearch-Dashboards/plugins/gantt-chart
yarn lint:style
- name: Test
run: |
cd ./dashboards-visualizations/OpenSearch-Dashboards/plugins/gantt-chart
Expand All @@ -183,5 +190,3 @@ jobs:
with:
name: gantt-chart-macos
path: ./dashboards-visualizations/OpenSearch-Dashboards/plugins/gantt-chart/build


1 change: 1 addition & 0 deletions gantt-chart/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
"osd": "node ../../scripts/osd",
"opensearch": "node ../../scripts/opensearch",
"lint": "eslint .",
"lint:style": "node ../../scripts/stylelint",
"build": "yarn plugin-helpers build",
"plugin-helpers": "node ../../scripts/plugin_helpers",
"test": "../../node_modules/.bin/jest --config ./test/jest.config.js",
Expand Down
2 changes: 1 addition & 1 deletion gantt-chart/public/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* SPDX-License-Identifier: Apache-2.0
*/

.embPanel__content[data-loading][data-type=plotlyGanttChart] {
.embPanel__content[data-loading][data-type="plotlyGanttChart"] {
pointer-events: auto;
filter: none;
}
Loading