Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP ] OverviewPage made with Content Management #2036

Closed
wants to merge 23 commits into from

Conversation

TackAdam
Copy link
Collaborator

@TackAdam TackAdam commented Aug 2, 2024

Description

  1. Implement the overview page using content management.
    New core plugin for dynamic content rendering OpenSearch-Dashboards#7201
  2. Add a setting for Observability default dashboard.

(Overview of functionality)

Example.mov

(Before the change)
Overview_Before

(After the change)
Overview_After
Overview_SelectedDashboard

(The setting)
By default is empty, once the user selects a dashboard in the overview page it is updated so that it persist when they return to the page.
Default-dasboards

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

props.setStartDate(onTimeChangeProps.start);
props.setEndDate(onTimeChangeProps.end);

coreRefs.contentManagement?.updatePageSection(HOME_CONTENT_AREAS.DASHBOARD, (section) => {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allows the date-picker to update the displayed dashboard. Pending opensearch-project/OpenSearch-Dashboards#7651

@ps48
Copy link
Member

ps48 commented Aug 12, 2024

@danieldong51 Can you please resolve the conflicts here

@@ -3,159 +3,239 @@
* SPDX-License-Identifier: Apache-2.0
*/

import React, { useState, useEffect } from 'react';
import React, { useEffect, useState } from 'react';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please add some jest, cypress tests here.

TackAdam and others added 23 commits August 20, 2024 10:10
Signed-off-by: Adam Tackett <[email protected]>
Co-authored-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
* fix direct url load for trace analytics

Signed-off-by: Shenoy Pratik <[email protected]>

* update side nav link

Signed-off-by: Shenoy Pratik <[email protected]>

---------

Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Co-authored-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
…ch-project#2037)

* bugfix ids and breadcrumbs

Signed-off-by: Adam Tackett <[email protected]>

* remove comments

Signed-off-by: Adam Tackett <[email protected]>

* quick fix

Signed-off-by: Adam Tackett <[email protected]>

---------

Signed-off-by: Adam Tackett <[email protected]>
Co-authored-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
* add job scheduler to observability CI

Signed-off-by: Shenoy Pratik <[email protected]>

* update workflow for integ tests

Signed-off-by: Shenoy Pratik <[email protected]>

* remove datasources test

Signed-off-by: Shenoy Pratik <[email protected]>

* exclude localhost links from link checker

Signed-off-by: Shenoy Pratik <[email protected]>

* update links for link checker

Signed-off-by: Shenoy Pratik <[email protected]>

---------

Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
* Move the save button to the header control bar

Signed-off-by: Ryan Liang <[email protected]>

* Update snapshots

Signed-off-by: Ryan Liang <[email protected]>

* Fix the save button and correct its size + position

Signed-off-by: Ryan Liang <[email protected]>

* Fix the date picker location

Signed-off-by: Ryan Liang <[email protected]>

* Rename the navigation in coreRef and switch to use compressed date picker

Signed-off-by: Ryan Liang <[email protected]>

* Fix the popover

Signed-off-by: Ryan Liang <[email protected]>

* Rename the button

Signed-off-by: Ryan Liang <[email protected]>

* Update to latest mockup

Signed-off-by: Ryan Liang <[email protected]>

* Update snapshots

Signed-off-by: Ryan Liang <[email protected]>

* Fix the ui issues

Signed-off-by: Ryan Liang <[email protected]>

* Dummy metrics

Signed-off-by: Ryan Liang <[email protected]>

* Remove dummy

Signed-off-by: Ryan Liang <[email protected]>

* update snapshots

Signed-off-by: Ryan Liang <[email protected]>

* minor changes to match mocks

Signed-off-by: Shenoy Pratik <[email protected]>

---------

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Co-authored-by: Shenoy Pratik <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
…roject#2048)

* first step of MDS

Signed-off-by: Adam Tackett <[email protected]>

* add mds support to getting started

Signed-off-by: Adam Tackett <[email protected]>

* update references, renaming, code cleanup

Signed-off-by: Adam Tackett <[email protected]>

* update snapshots, remove depend

Signed-off-by: Adam Tackett <[email protected]>

* only add mds reference to index patterns

Signed-off-by: Adam Tackett <[email protected]>

---------

Signed-off-by: Adam Tackett <[email protected]>
Co-authored-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
…pensearch-project#2068)

* Use EuiSmallButton

Signed-off-by: Miki <[email protected]>

* Use EuiSmallButtonIcon

Signed-off-by: Miki <[email protected]>

* Use EuiSmallButtonEmpty

Signed-off-by: Miki <[email protected]>

* Use EuiCompressedFormRow

Signed-off-by: Miki <[email protected]>

* Use EuiCompressedField*

Signed-off-by: Miki <[email protected]>

* Use EuiCompressedSelect and EuiCompressedSuperSelect

Signed-off-by: Miki <[email protected]>

* Use EuiCompressedFilePicker

Signed-off-by: Miki <[email protected]>

* Use EuiCompressedRadio and EuiCompressedRadioGroup

Signed-off-by: Miki <[email protected]>

* Use EuiCompressedSwitch

Signed-off-by: Miki <[email protected]>

* Use EuiCompressedEuiTextArea

Signed-off-by: Miki <[email protected]>

* Use EuiCompressedComboBox

Signed-off-by: Miki <[email protected]>

* Use EuiSmallFilterButton

Signed-off-by: Miki <[email protected]>

* Undo unnecessary EuiSmallButton* uses

Signed-off-by: Miki <[email protected]>

* Use EuiCompressedSuperDatePicker

Signed-off-by: Miki <[email protected]>

* Fix tests and snapshots

Signed-off-by: Miki <[email protected]>

* Fix tests and snapshots

Signed-off-by: Miki <[email protected]>

---------

Signed-off-by: Miki <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Dan Dong <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Dan Dong <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Dan Dong <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Dan Dong <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Dan Dong <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Dan Dong <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Dan Dong <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants