Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Remove ag grid package #2001

Merged
merged 3 commits into from
Jul 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,11 @@
]
},
"dependencies": {
"@ag-grid-community/styles": "^31.3.4",
"@algolia/autocomplete-core": "^1.4.1",
"@algolia/autocomplete-theme-classic": "^1.2.1",
"@nteract/outputs": "^3.0.11",
"@nteract/presentational-components": "^3.4.3",
"@reduxjs/toolkit": "^1.6.1",
"ag-grid-react": "^31.3.4",
"ajv": "^8.11.0",
"antlr4": "4.8.0",
"antlr4ts": "^0.5.0-alpha.4",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,20 @@
*/

import React, { useState, useMemo } from 'react';
import isEmpty from 'lodash/isEmpty';

Check failure on line 7 in public/components/event_analytics/explorer/visualizations/workspace_panel/workspace_panel.tsx

View workflow job for this annotation

GitHub Actions / Lint

'isEmpty' is defined but never used. Allowed unused vars must match /^_/u
import { EuiPanel, EuiSwitch } from '@elastic/eui';

Check failure on line 8 in public/components/event_analytics/explorer/visualizations/workspace_panel/workspace_panel.tsx

View workflow job for this annotation

GitHub Actions / Lint

'EuiSwitch' is defined but never used. Allowed unused vars must match /^_/u
import { Visualization } from '../../../../visualizations/visualization';
import { DataTable } from '../../../../visualizations/charts/data_table/data_table';
import { uiSettingsService } from '../../../../../../common/utils';

interface IWorkSpacePanel {
curVisId: string;
setCurVisId: any;

Check warning on line 15 in public/components/event_analytics/explorer/visualizations/workspace_panel/workspace_panel.tsx

View workflow job for this annotation

GitHub Actions / Lint

Unexpected any. Specify a different type
visualizations: any;

Check warning on line 16 in public/components/event_analytics/explorer/visualizations/workspace_panel/workspace_panel.tsx

View workflow job for this annotation

GitHub Actions / Lint

Unexpected any. Specify a different type
}

export function WorkspacePanel({ visualizations }: IWorkSpacePanel) {
const [isTableViewOn, setIsTableViewOn] = useState(false);

Check failure on line 20 in public/components/event_analytics/explorer/visualizations/workspace_panel/workspace_panel.tsx

View workflow job for this annotation

GitHub Actions / Lint

'setIsTableViewOn' is assigned a value but never used. Allowed unused vars must match /^_/u
const VisualizationPanel = useMemo(() => {
return (
<Visualization visualizations={visualizations} data-test-subj="workspace__visualizations" />
Expand All @@ -26,21 +26,6 @@

return (
<div className="explorerViz__commonPanel ws__workspace_visPanel">
<EuiPanel className="workspace_visPanel" paddingSize="s" color="plain" hasBorder={false}>
<EuiSwitch
className="workspace_visPanel--switch"
label="Table view"
type="button"
disabled={isEmpty(visualizations?.data?.explorer?.explorerData)}
checked={isTableViewOn}
onChange={() => {
setIsTableViewOn((staleState) => !staleState);
}}
aria-describedby="table view switcher"
data-test-subj="workspace__dataTableViewSwitch"
compressed
/>
</EuiPanel>
<EuiPanel
paddingSize="s"
className={`ws__workspace_visPanel--space ${
Expand Down

This file was deleted.

This file was deleted.

Loading
Loading