-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update data layer source name #588
Update data layer source name #588
Conversation
Signed-off-by: Junqiu Lei <[email protected]>
392edfb
to
1507138
Compare
Unrelated test failure due to OSD issue opensearch-project/OpenSearch-Dashboards#5561 (comment), adding |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #588 +/- ##
=======================================
Coverage 41.36% 41.36%
=======================================
Files 53 53
Lines 1789 1789
Branches 328 328
=======================================
Hits 740 740
Misses 1019 1019
Partials 30 30 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Junqiu Lei <[email protected]>
a1e0044
to
1b41da4
Compare
One cypress test failed on CI but passed at my local, cut issue separately #592
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@junqiu-lei Do we need change in documentation website too? i remember sharing screenshot with select data source. |
Sure, will raise PR to document repo if change needed. |
* Update data layer source name Signed-off-by: Junqiu Lei <[email protected]> (cherry picked from commit 0647a71)
* Update data layer source name Signed-off-by: Junqiu Lei <[email protected]> (cherry picked from commit 0647a71) Co-authored-by: Junqiu Lei <[email protected]>
Description
Update layer source name from
Data source
toIndex pattern
followed from #584 (comment)Issues Resolved
#584
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.