Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving and expanding functionality checks for the workflow_detail page #360

Merged
merged 12 commits into from
Sep 11, 2024

Conversation

saimedhi
Copy link
Collaborator

@saimedhi saimedhi commented Sep 10, 2024

Description

Improving and expanding functionality checks for the workflow_detail page. Added tests for below functionalities.

  • The "Create an ingest pipeline" option is selected by default
  • The "Skip ingestion pipeline" option is disabled by default
  • The "Run ingestion" button is enabled by default
  • The "Search pipeline >" button is disabled by default
  • Clicking the "close" button goes back to the list page
  • Clicking the "export" button opens the export component
  • Collapsing the "Tools" panels hides those components
  • The default components in the ReactFlow workspace are visible. Default- Visual.

Issues Resolved

Related to #95

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ohltyler ohltyler added the test label Sep 10, 2024
@saimedhi saimedhi marked this pull request as draft September 11, 2024 03:04
@saimedhi saimedhi marked this pull request as ready for review September 11, 2024 19:10
Signed-off-by: Sai Medhini Reddy Maryada <[email protected]>
Copy link
Member

@ohltyler ohltyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@saimedhi saimedhi merged commit 7e704d9 into opensearch-project:main Sep 11, 2024
6 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 11, 2024
…page (#360)

* Improving and expanding functionality checks for the workflow_detail page

Signed-off-by: saimedhi <[email protected]>

* Improving and expanding functionality checks for the workflow_detail page

Signed-off-by: saimedhi <[email protected]>

* Improving and expanding functionality checks for the workflow_detail page

Signed-off-by: saimedhi <[email protected]>

* Improving and expanding functionality checks for the workflow_detail page

Signed-off-by: saimedhi <[email protected]>

* Improving and expanding functionality checks for the workflow_detail page

Signed-off-by: saimedhi <[email protected]>

* Improving and expanding functionality checks for the workflow_detail page

Signed-off-by: saimedhi <[email protected]>

* Improving and expanding functionality checks for the workflow_detail page

Signed-off-by: saimedhi <[email protected]>

* Improving and expanding functionality checks for the workflow_detail page

Signed-off-by: saimedhi <[email protected]>

---------

Signed-off-by: saimedhi <[email protected]>
Signed-off-by: Sai Medhini Reddy Maryada <[email protected]>
(cherry picked from commit 7e704d9)
saimedhi added a commit that referenced this pull request Sep 11, 2024
…page (#360) (#366)

* Improving and expanding functionality checks for the workflow_detail page

Signed-off-by: saimedhi <[email protected]>

* Improving and expanding functionality checks for the workflow_detail page

Signed-off-by: saimedhi <[email protected]>

* Improving and expanding functionality checks for the workflow_detail page

Signed-off-by: saimedhi <[email protected]>

* Improving and expanding functionality checks for the workflow_detail page

Signed-off-by: saimedhi <[email protected]>

* Improving and expanding functionality checks for the workflow_detail page

Signed-off-by: saimedhi <[email protected]>

* Improving and expanding functionality checks for the workflow_detail page

Signed-off-by: saimedhi <[email protected]>

* Improving and expanding functionality checks for the workflow_detail page

Signed-off-by: saimedhi <[email protected]>

* Improving and expanding functionality checks for the workflow_detail page

Signed-off-by: saimedhi <[email protected]>

---------

Signed-off-by: saimedhi <[email protected]>
Signed-off-by: Sai Medhini Reddy Maryada <[email protected]>
(cherry picked from commit 7e704d9)

Co-authored-by: Sai Medhini Reddy Maryada <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants