Support multiple input/output maps for ML processors #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz and
jackiehanyang
as code owners
public/pages/workflow_detail/workflow_inputs/input_fields/map_array_field.tsx
Show resolved
Hide resolved
public/pages/workflow_detail/workflow_inputs/processor_inputs/input_transform_modal.tsx
Outdated
Show resolved
Hide resolved
public/pages/workflow_detail/workflow_inputs/processor_inputs/input_transform_modal.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Tyler Ohlsen <[email protected]>
jackiehanyang
approved these changes
Jul 26, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 26, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit e908023)
ohltyler
added a commit
that referenced
this pull request
Jul 26, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit e908023) Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR expands the form inputs for the input map / output map fields for ML processors, to be a list of maps, instead of a single map. This is so multiple predict/inference calls can happen within a single processor's execution. At a high level, this means changing the form, schema, and components to maintain an arr of maps instead of a single one.
Additionally, In the advanced transform modals, users can now select which predict/inference call they want to test out and see test transformation results of.
More specific details:
mapArrayconfig field typeMapArrayFieldwhich takes in aFormik's arr field and maintains an arr of individualMapFieldsmapArrayfield type, used in the ML processor'sinputMap/outputMapfieldsTesting
Demo video, showing configuration of multiple prediction/inference mappings configured in the input and output maps, validation of mismatching, and transformation testing within the input transform modal and output transform modals:
screen-capture.12.webm
Issues Resolved
Makes progress on #23
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.