feat: support navigating to discover in alerting popover #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raintygao
changed the title
raintygao
requested review from
lezzago,
joshuali925,
anirudha,
ruanyl,
SuZhou-Joe,
xluo-aws,
gaobinlong,
Hailong-am and
wanglam
as code owners
Signed-off-by: tygao <[email protected]>
Signed-off-by: tygao <[email protected]>
Signed-off-by: tygao <[email protected]>
Signed-off-by: tygao <[email protected]>
Hailong-am
reviewed
Sep 20, 2024
Comment on lines
+190
to
+194
| const timeDslIndex = filters?.findIndex((filter: Record<string, string>) => filter?.range); | ||
| const timeDsl = filters[timeDslIndex]?.range; | ||
| const timeFieldName = Object.keys(timeDsl)[0]; | ||
| if (!timeFieldName) return; | ||
| filters?.splice(timeDslIndex, 1); |
There was a problem hiding this comment.
there could have multiple range filters in filters and date range is not the first one
{
"size": 0,
"query": {
"bool": {
"filter": [
{
"range": {
"total_quantity": {
"from": 1,
"to": 5,
"include_lower": true,
"include_upper": true,
"boost": 1
}
}
},
{
"range": {
"order_date": {
"from": "{{period_end}}||-1h",
"to": "{{period_end}}",
"include_lower": true,
"include_upper": true,
"format": "epoch_millis",
"boost": 1
}
}
}
],
"adjust_pure_negative": true,
"boost": 1
}
}
}There was a problem hiding this comment.
In which case will this DSL exist? I was told offline there only be one range in DSL, if so, this could be a potential issue.
There was a problem hiding this comment.
What does period_end mean?
There was a problem hiding this comment.
In which case will this DSL exist? I was told offline there only be one range in DSL, if so, this could be a potential issue.
This is a manual input query DSL. From create monitor page, if i add more range filters they will not at the first. It will looks like below, and the code logic is find first range filter, work for most cases.
"query": {
"size": 0,
"aggregations": {},
"query": {
"bool": {
"filter": [
{
"range": {
"order_date": {
"gte": "{{period_end}}||-1h",
"lte": "{{period_end}}",
"format": "epoch_millis"
}
}
},
{
"range": {
"products.price": {
"gte": 10,
"lte": 20
}
}
}
]
}
}
}What does period_end mean?
this is placeholder to actual trigger time.
There was a problem hiding this comment.
There still have other edge cases, like customized query don't have range filter. For POC we can ignore it.
Hailong-am
reviewed
Sep 20, 2024
Hailong-am
approved these changes
Sep 20, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
* feat: support navigate to discover in alerting popover Signed-off-by: tygao <[email protected]> * feat: support MDS and fix test env error Signed-off-by: tygao <[email protected]> * doc: add changelog Signed-off-by: tygao <[email protected]> * add tests Signed-off-by: tygao <[email protected]> --------- Signed-off-by: tygao <[email protected]> (cherry picked from commit 93744fe) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
raintygao
pushed a commit
that referenced
this pull request
Sep 20, 2024
* feat: support navigate to discover in alerting popover Signed-off-by: tygao <[email protected]> * feat: support MDS and fix test env error Signed-off-by: tygao <[email protected]> * doc: add changelog Signed-off-by: tygao <[email protected]> * add tests Signed-off-by: tygao <[email protected]> --------- Signed-off-by: tygao <[email protected]> (cherry picked from commit 93744fe) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
support navigating to discover in alerting popover
Screen shot
-.2024-09-14.6_33_33.mp4
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.