disable index patterns which data source has no agent configured for text to visualization #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
text to visualization + extract vega json object from the response which is supposed to be in between tag <vega-lite></vega-lite> Signed-off-by: Yulong Ruan <[email protected]>
ruanyl
requested review from
lezzago,
joshuali925,
anirudha,
SuZhou-Joe,
xluo-aws,
gaobinlong,
Hailong-am,
wanglam and
raintygao
as code owners
Hailong-am
reviewed
Sep 13, 2024
common/constants/llm.ts
Outdated
| @@ -43,3 +43,6 @@ export const NOTEBOOK_API = { | |||
| export const DEFAULT_USER_NAME = 'User'; | |||
|
|
|||
| export const TEXT2VEGA_INPUT_SIZE_LIMIT = 400; | |||
|
|
|||
| export const TEXT2VEGA_AGENT_CONFIG_ID = 'os_text2vega_new2'; | |||
There was a problem hiding this comment.
My bad, need to clean that up, it's for testing.
There was a problem hiding this comment.
@Hailong-am This is fixed now, could you please take another look? Thanks!
There was a problem hiding this comment.
thanks, it looks good to me
Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
4 tasks
Hailong-am
approved these changes
Sep 18, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 18, 2024
…text to visualization (#310) * disable index patterns which data source has no agent configured for text to visualization + extract vega json object from the response which is supposed to be in between tag <vega-lite></vega-lite> Signed-off-by: Yulong Ruan <[email protected]> * text2viz only support opensearch type of data source Signed-off-by: Yulong Ruan <[email protected]> * update changelogs Signed-off-by: Yulong Ruan <[email protected]> --------- Signed-off-by: Yulong Ruan <[email protected]> (cherry picked from commit 67e920c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
ruanyl
pushed a commit
that referenced
this pull request
Sep 20, 2024
…text to visualization (#310) (#314) * disable index patterns which data source has no agent configured for text to visualization + extract vega json object from the response which is supposed to be in between tag <vega-lite></vega-lite> Signed-off-by: Yulong Ruan <[email protected]> * text2viz only support opensearch type of data source Signed-off-by: Yulong Ruan <[email protected]> * update changelogs Signed-off-by: Yulong Ruan <[email protected]> --------- Signed-off-by: Yulong Ruan <[email protected]> (cherry picked from commit 67e920c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.