feat: expose an API to check if a give agent config name has agent id configured #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
configured + use agentConfigName instead of agentName to avoid confusing Signed-off-by: Yulong Ruan <[email protected]>
ruanyl
requested review from
lezzago,
joshuali925,
anirudha,
SuZhou-Joe,
xluo-aws,
gaobinlong,
Hailong-am,
wanglam and
raintygao
as code owners
Hailong-am
approved these changes
Sep 13, 2024
Hailong-am
reviewed
Sep 13, 2024
| @@ -21,7 +21,7 @@ export function registerAgentRoutes(router: IRouter, assistantService: Assistant | |||
| }), | |||
| schema.object({ | |||
| dataSourceId: schema.maybe(schema.string()), | |||
| agentName: schema.string(), | |||
| agentConfigName: schema.string(), | |||
There was a problem hiding this comment.
do we have any plugins using this API? they may need to change the name as well
There was a problem hiding this comment.
Yes, will sync with the plugin owners.
Signed-off-by: Yulong Ruan <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 13, 2024
… configured (#307) * feat: expose an API to check if a give agent config name has agent id configured + use agentConfigName instead of agentName to avoid confusing Signed-off-by: Yulong Ruan <[email protected]> * add changelogs Signed-off-by: Yulong Ruan <[email protected]> --------- Signed-off-by: Yulong Ruan <[email protected]> (cherry picked from commit 6ee6a8d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
ruanyl
pushed a commit
that referenced
this pull request
Sep 14, 2024
… configured (#307) (#309) * feat: expose an API to check if a give agent config name has agent id configured + use agentConfigName instead of agentName to avoid confusing Signed-off-by: Yulong Ruan <[email protected]> * add changelogs Signed-off-by: Yulong Ruan <[email protected]> --------- Signed-off-by: Yulong Ruan <[email protected]> (cherry picked from commit 6ee6a8d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
namefieldDescription
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.