Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric report for thumbup and thumbdown buttons in chat #263

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

chishui
Copy link
Contributor

@chishui chishui commented Aug 21, 2024

Description

Whenever users click thumb-up and thumb-down buttons, we emit a click event using usage_collection plugin. The data will be save to kibana index through savedObject.

Things to note:

  1. Append a UUID after metric name so that each click event haves their own document and we have a way to aggregate docs within a timeframe.
  2. Need to enable this flag usageCollection.uiMetric.enabled: true to enable reporting.

Issues Resolved

#262

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test.
  • New functionality has user manual doc added.
  • Commits are signed per the DCO using --signoff.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.41%. Comparing base (4f33fa0) to head (f8a1d4d).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #263      +/-   ##
==========================================
- Coverage   90.34%   89.41%   -0.94%     
==========================================
  Files          59       60       +1     
  Lines        1575     1672      +97     
  Branches      377      412      +35     
==========================================
+ Hits         1423     1495      +72     
- Misses        150      175      +25     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gaobinlong gaobinlong added backport 2.x Trigger the backport flow to 2.x v2.17.0 labels Sep 4, 2024
@ruanyl ruanyl removed the v2.17.0 label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Trigger the backport flow to 2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants