Support creating alert in the chat window #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Heng Qian <[email protected]>
qianheng-aws
requested review from
lezzago,
joshuali925,
anirudha,
ruanyl,
SuZhou-Joe,
xluo-aws,
gaobinlong,
Hailong-am,
wanglam and
raintygao
as code owners
Signed-off-by: Heng Qian <[email protected]>
wanglam
reviewed
Jul 22, 2024
| @@ -86,52 +87,55 @@ export const ChatFlyout = (props: ChatFlyoutProps) => { | |||
| > | |||
| <> | |||
| <div className={cs('llm-chat-flyout-header')}> | |||
| <ChatWindowHeader /> | |||
| {props.overrideComponent ? <ChatOverrideHeader /> : <ChatWindowHeader />} | |||
There was a problem hiding this comment.
Is this ChatOverrideHeader suitable for all override component header? Shall we just hide the ChatWindowHeader and let overrideComponent take over the whole screen?
There was a problem hiding this comment.
Yes, I think this is a standard header for all override component. As UX required, we should change the title, add a back button and hide the history button. There is a mock up for AD, which also applies to alert.
Signed-off-by: Heng Qian <[email protected]>
Signed-off-by: Heng Qian <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #217 +/- ##
==========================================
- Coverage 90.02% 89.40% -0.62%
==========================================
Files 54 60 +6
Lines 1433 1623 +190
Branches 347 394 +47
==========================================
+ Hits 1290 1451 +161
- Misses 141 169 +28
- Partials 2 3 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Heng Qian <[email protected]>
# Conflicts: # CHANGELOG.md # public/types.ts
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support creating alert in the chat window as a follow-up question of alert analysis
Expected results of creating alert in chatbot:
Issues Resolved
#216
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.