Add support to ignore updates on autofollow pattern #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ankit Kala <[email protected]>
ankitkala
requested review from
krishna-ggk,
saikaranam-amazon,
soosinha,
gbbafna and
monusingh-1
as code owners
This was referenced Sep 10, 2024
Signed-off-by: Ankit Kala <[email protected]>
monusingh-1
previously approved these changes
Sep 10, 2024
Signed-off-by: Ankit Kala <[email protected]>
monusingh-1
approved these changes
Sep 10, 2024
soosinha
reviewed
Sep 11, 2024
| assertThat(response.isAcknowledged).isTrue() | ||
| } catch (e: ResponseException) { | ||
| // Skip if ignoreIfExists is true and exception contains resource_already_exists_exception | ||
| if ((ignoreIfExists == true && e.message?.contains("resource_already_exists_exception")!!) == false) throw e |
There was a problem hiding this comment.
If ignoreIfExists is false then exception will not be thrown. Is that the expected behavior.
There was a problem hiding this comment.
sorry, the check is slightly confusing. If ignoreIfExists is false, it will throw the exception
soosinha
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
#1433
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.