[Backport 2.1] Handling OpenSearchRejectExecuteException Exception (#1004) #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct#1004) * Handling OpenSearchRejectExecuteException Exception * introduced writersPerShard setting. Signed-off-by: sricharanvuppu <[email protected]> (cherry picked from commit 448e7a7) Signed-off-by: sricharanvuppu <[email protected]>
Signed-off-by: sricharanvuppu <[email protected]>
sricharanvuppu
force-pushed
the
backport/backport-1004-to-2.1
branch
from
92b4c44
to
5bc8b90
Compare
Codecov Report
@@ Coverage Diff @@
## 2.1 #1023 +/- ##
============================================
+ Coverage 69.83% 76.41% +6.58%
- Complexity 956 1037 +81
============================================
Files 141 141
Lines 4674 4707 +33
Branches 519 525 +6
============================================
+ Hits 3264 3597 +333
+ Misses 1079 778 -301
- Partials 331 332 +1
|
monusingh-1
requested changes
Jul 7, 2023
| var highWatermark = initialSeqNo | ||
| for (m in channel) { | ||
| rateLimiter.acquire() |
There was a problem hiding this comment.
This should not be here, can you move it to before the while statement.
Signed-off-by: sricharanvuppu <[email protected]>
monusingh-1
approved these changes
Oct 4, 2023
ankitkala
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.