Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added indexing user activity events operation #19

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

bshien
Copy link
Contributor

@bshien bshien commented Oct 3, 2024

Description

Coming from opensearch-project/opensearch-metrics#76

Added operation to index events pertaining to user activity into an OpenSearch cluster for further processing to monitor Maintainer activity.

Issues Resolved

Part of opensearch-project/opensearch-metrics#57

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@bshien bshien force-pushed the index-events-2 branch 2 times, most recently from 68ffd3f to 476f61e Compare October 3, 2024 18:20
@bshien bshien changed the title Added indexing maintainer events operation Added indexing user events operation Oct 3, 2024
@bshien bshien changed the title Added indexing user events operation Added indexing user activity events operation Oct 3, 2024
@bshien bshien force-pushed the index-events-2 branch 3 times, most recently from 0231394 to 4fde209 Compare October 3, 2024 20:10
@bshien bshien marked this pull request as ready for review October 4, 2024 21:21
Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bshien

Please rebase on main and resolve conflicts as a few files already updated by @prudhvigodithi in #21.

Thanks.

package.json Outdated Show resolved Hide resolved
src/call/github-activity-events-monitor.ts Show resolved Hide resolved
@bshien bshien force-pushed the index-events-2 branch 2 times, most recently from f50741f to 974fa81 Compare October 4, 2024 22:10
Comment on lines 5 to 22
- issues.opened
- issues.closed
- issues.labeled
- issues.unlabeled
- issues.transferred
- issues.assigned
- issue_comment.created
- push
- pull_request.closed
- pull_request.opened
- pull_request.labeled
- pull_request.unlabeled
- pull_request.assigned
- pull_request_review.submitted
- pull_request_review_comment.created
- gollum
- release.released
- project.edited
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These needs to be enabled in opensearch-infra app before take effect.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, it would be great if you could enable these. If we don't want to enable it's ok because most of the activity is coming from issue and pull_request

Copy link
Member

@peterzhuamazon peterzhuamazon Oct 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably can ignore the project.edited for now and release.released.

I would start with the issues, pull_request and gollum now and bake for a few days.

You can comment out the others.

@bshien bshien force-pushed the index-events-2 branch 2 times, most recently from 8096d24 to bf878a3 Compare October 4, 2024 22:41
Comment on lines 12 to 22
# - push
- pull_request.closed
- pull_request.opened
- pull_request.labeled
- pull_request.unlabeled
- pull_request.assigned
- pull_request_review.submitted
- pull_request_review_comment.created
- gollum
# - release.released
# - project.edited
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spacing, or probably move all three commented ones to the bottom of the array.

@peterzhuamazon peterzhuamazon merged commit 0f5ca46 into opensearch-project:main Oct 4, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants