Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Strings and OpenSearchException to core lib #911

Closed
wants to merge 1 commit into from
Closed

[Refactor] Strings and OpenSearchException to core lib #911

wants to merge 1 commit into from

Conversation

nknize
Copy link

@nknize nknize commented May 22, 2023

Updates codebase to use new opensearch-core library for Strings and BaseOpenSearchException upstream refactor changes.

relates opensearch-project/OpenSearch#5910

@nknize
[Refactor] Strings and OpenSearchException to core lib
1f40450 
Updates codebase to use new opensearch-core library for Strings and
BaseOpenSearchException upstream refactor changes.

Signed-off-by: Nicholas Walter Knize <[email protected]>
@nknize nknize added the enhancement New feature or request label May 22, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot added backport 2.x infra Changes to infrastructure, testing, CI/CD, pipelines, etc. labels May 22, 2023
sudiptoguha
sudiptoguha approved these changes May 22, 2023
View reviewed changes
Copy link

@sudiptoguha sudiptoguha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@nknize
Copy link
Author

nknize commented May 23, 2023

The code change is fine. The build is fine. The integTest cluster is picking up a bad classpath for some reason that doesn't include opensearch-core.jar library. Usually this is fixed through testRuntimeOnly dependency in build.gradle but that's not having an affect. Even adding integTestRuntimeOnly config isn't having an affect. I haven't dug deeper than that so this will need a deeper look. Since something is up w/ the integTest classpath.

@nknize
Copy link
Author

nknize commented May 23, 2023

Oh I see why... the last published zip archive is dated Feb 01.. so the extracted opensearch-core-3.0.0-SNAPSHOT.jar doesn't contain the new org.opensearch.core.common.Strings class.. hence NoClassDefFound. @bbarani, do you publish nightly zip archive distros? Or just the jar files? Integ tests that use the zip archive will fail if they aren't current w/ the latest nightly jar.

@kaituo
Copy link
Collaborator

kaituo commented Aug 15, 2023

close the PR as other PR has already fixed the issue.

@kaituo kaituo closed this Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudiptoguha sudiptoguha sudiptoguha approved these changes

@jmazanec15 jmazanec15 Awaiting requested review from jmazanec15 jmazanec15 is a code owner

@jngz-es jngz-es Awaiting requested review from jngz-es jngz-es is a code owner

@kaituo kaituo Awaiting requested review from kaituo kaituo is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@ohltyler ohltyler Awaiting requested review from ohltyler ohltyler is a code owner

@vamshin vamshin Awaiting requested review from vamshin vamshin is a code owner

@VijayanB VijayanB Awaiting requested review from VijayanB VijayanB is a code owner

@ylwu-amzn ylwu-amzn Awaiting requested review from ylwu-amzn ylwu-amzn is a code owner

@amitgalitz amitgalitz Awaiting requested review from amitgalitz amitgalitz is a code owner

@jackiehanyang jackiehanyang Awaiting requested review from jackiehanyang jackiehanyang is a code owner

@sean-zheng-amazon sean-zheng-amazon Awaiting requested review from sean-zheng-amazon sean-zheng-amazon is a code owner

Assignees
No one assigned
Labels
backport 2.x enhancement New feature or request infra Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nknize @kaituo @sudiptoguha