Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flatten_result_index_mapping field to Config #1317

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

jackiehanyang
Copy link
Collaborator

Description

This pr backports #1276 into 2.x branch

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Jackie Han <[email protected]>
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 76.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 77.64%. Comparing base (138dbd0) to head (7073299).
Report is 25 commits behind head on 2.x.

Files with missing lines Patch % Lines
.../java/org/opensearch/ad/model/AnomalyDetector.java 75.00% 1 Missing and 1 partial ⚠️
...java/org/opensearch/forecast/model/Forecaster.java 33.33% 2 Missing ⚠️
...n/java/org/opensearch/timeseries/model/Config.java 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #1317      +/-   ##
============================================
+ Coverage     71.40%   77.64%   +6.24%     
- Complexity     4878     5469     +591     
============================================
  Files           518      533      +15     
  Lines         22931    23334     +403     
  Branches       2260     2311      +51     
============================================
+ Hits          16373    18118    +1745     
+ Misses         5509     4159    -1350     
- Partials       1049     1057       +8     
Flag Coverage Δ
plugin 77.64% <76.00%> (+6.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/main/java/org/opensearch/ad/model/ADTask.java 98.00% <100.00%> (+<0.01%) ⬆️
.../handler/AbstractAnomalyDetectorActionHandler.java 100.00% <100.00%> (+80.00%) ⬆️
...va/org/opensearch/forecast/model/ForecastTask.java 97.99% <100.00%> (+0.41%) ⬆️
.../rest/handler/AbstractForecasterActionHandler.java 91.11% <100.00%> (+91.11%) ⬆️
.../java/org/opensearch/ad/model/AnomalyDetector.java 86.08% <75.00%> (-0.95%) ⬇️
...java/org/opensearch/forecast/model/Forecaster.java 78.10% <33.33%> (+7.02%) ⬆️
...n/java/org/opensearch/timeseries/model/Config.java 85.30% <66.66%> (-1.72%) ⬇️

... and 110 files with indirect coverage changes

@jackiehanyang jackiehanyang merged commit cbe1f33 into opensearch-project:2.x Sep 20, 2024
28 of 29 checks passed
jackiehanyang added a commit to jackiehanyang/anomaly-detection that referenced this pull request Oct 22, 2024
jackiehanyang added a commit that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants