[Backport to 2.x] Refinement of Forecasting and AD Precision/Recall Improvements #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaituo
requested review from
jmazanec15,
jngz-es,
saratvemulapalli,
ohltyler,
vamshin,
VijayanB,
ylwu-amzn,
amitgalitz,
jackiehanyang,
sean-zheng-amazon,
dbwiddis,
owaiskazi19 and
joshpalis
as code owners
…earch-project#1210) This PR addresses several improvements related to forecasting and anomaly detection (AD) precision/recall. It introduces changes to accommodate forecasting functionality, which is currently disabled as it's not yet released. Additionally, it reverts name changes introduced in a previous PR opensearch-project#1173 due to the unreleased status of forecasting. Changes Made: * Integration of forecasting-related improvements. * Reversion of name changes for compatibility reasons. * Introduce rule based AD. Testing Done: * Verified frontend workflow remains functional: creation, previewing, historical, and real-time detection. * All existing unit and integration tests pass successfully. * Added a new integration test (RuleModelPerfIT) to validate rule-based AD improvements in precision/recall. Next Steps: * Add new AD tests before the 2.15 release to meet coverage requirements. * Conduct backward compatibility tests to ensure compatibility with existing functionality. The merge was attempted earlier to prevent blocking other teammates from submitting their changes. Signed-off-by: Kaituo Li <[email protected]>
jackiehanyang
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
backport #1210 to 2.x
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.