Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Updates sample cert and admin keystore #1177

Closed
wants to merge 107 commits into from

Conversation

joshpalis
Copy link
Member

Description

Manual backport of #1163

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

aksingh-es and others added 30 commits April 21, 2022 08:51
* Re enable tests for CI

Signed-off-by: aksingh-es <[email protected]>

* reenable CI tests

Signed-off-by: aksingh-es <[email protected]>

* fixing minor issue

Signed-off-by: aksingh-es <[email protected]>

* fixing minor issue for CI

Signed-off-by: aksingh-es <[email protected]>
(cherry picked from commit a44ffec)
Signed-off-by: Amit Galitzky <[email protected]>
(cherry picked from commit 8227e32)
…ensearch-project#545)

Signed-off-by: Amit Galitzky <[email protected]>
(cherry picked from commit dbd311a)

Co-authored-by: Amit Galitzky <[email protected]>
Signed-off-by: aksingh-es <[email protected]>
(cherry picked from commit 1ada5d7)
…pensearch-project#558)

* Use current time as training data end time

The bug happens because we use job enabled time as training data end time. But if the historical data before that time is deleted or does not exist at all, cold start might never finish. This PR uses current time as the training data end time so that cold start has a chance to succeed later. This PR also removes the code that combines cold start data and existing samples in EntityColdStartWorker because we don't add samples until cold start succeeds. Combining cold start data and existing samples is thus unnecessary.

Testing done:
1. manually verified the bug is fixed.
2. fixed all related unit tests.

Signed-off-by: Kaituo Li <[email protected]>
Signed-off-by: Amit Galitzky <[email protected]>
(cherry picked from commit 5f4f9cd)
Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit 7f3820a)
…ensearch-project#581)

* Disable interpolation in HCAD cold start

Previously, we used interpolation in HCAD cold start for the purpose of efficiency. This caused problems for model accuracy. This PR removes interpolation in the cold start step.

Testing done:
1. added unit tests to verify precision boosted.

Signed-off-by: Kaituo Li <[email protected]>
(cherry picked from commit 03e04d7)

Co-authored-by: Kaituo Li <[email protected]>
Signed-off-by: Amit Galitzky <[email protected]>
(cherry picked from commit 0e7079e)
Signed-off-by: Amit Galitzky <[email protected]>
(cherry picked from commit c6f9b20)
Signed-off-by: Amit Galitzky <[email protected]>
(cherry picked from commit 4d7a8a4)
Signed-off-by: Amit Galitzky <[email protected]>
(cherry picked from commit 0bd6e0e)
Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit d484f9b)
* Expose model accuracy metrics in tests

This PR adds an option flag to print logs during tests and turn on the flag in CI workflow. The flag is disabled by default. By doing this, we can record model accuracy metrics in git workflows and later retrieve it for analysis.

Testing done:
1. We can turn on/off logs during tests.
2. The accuracy logs are recorded.

Signed-off-by: Kaituo Li <[email protected]>
(cherry picked from commit f630c8f)
Signed-off-by: pgodithi <[email protected]>
(cherry picked from commit eb7bd07)
Signed-off-by: prudhvigodithi <[email protected]>
* make 1M1min possible

This PR improves performance to make the 1M1min experiment possible. First, I changed coordinating node pagination from sync to async mode in AnomalyResultTransportAction so that the coordinating node does not have to wait for model nodes' responses before fetching the next page. Second, during the million-entity evaluation, CPU is mostly around 1% with hourly spikes up to 65%. An internal hourly maintenance job can account for the spike due to saving hundreds of thousands of model checkpoints, clearing unused models, and performing bookkeeping for internal states. This PR evens out the resource usage more fairly across a large maintenance window by introducing CheckpointMaintainWorker. Third, during a model corruption, I retrigger cold start for mitigation. Check ModelManager.score, EntityResultTransportAction, and CheckpointReadWorker.

Testing done:
1. Added unit tests.
2. Manually confirmed 1M1min is possible after the above changes.

Signed-off-by: Kaituo Li <[email protected]>
(cherry picked from commit 08fdbdd)
Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit 7f84601)
Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit 12f9f2e)
Signed-off-by: Amit Galitzky <[email protected]>
(cherry picked from commit 01bbfc5)
2.2 added a new dependency of ClusterSettings like TaskResourceTrackingService. It is possible that the classloader that loadsTaskResourceTrackingService is different from the classloader that loads PowerMock and related dependencies. PowerMock reports java.lang.NoClassDefFoundError when initializing ClusterSettings. Since we are not actually using the value of ClusterSettings in the tests, we make it null to avoid initializing it. The change fixed failed tests.

This PR also fixed spotless errors in FakeNode due to recent changes.

Testing done:
* gradle build

Signed-off-by: Kaituo Li <[email protected]>
(cherry picked from commit c92cdc8)
…ide default distribution Download url (opensearch-project#380)

* Adding uasage and external property customDistributionUrl to let developer override default distribution Download url

Signed-off-by: Rishikesh1159 <[email protected]>

* Adding doc and removing system property from build.gradle

Signed-off-by: Rishikesh1159 <[email protected]>

Signed-off-by: Rishikesh1159 <[email protected]>
(cherry picked from commit bd063bd)
Signed-off-by: Amit Galitzky <[email protected]>
(cherry picked from commit 884573f)
Signed-off-by: cwillum <[email protected]>

Signed-off-by: cwillum <[email protected]>
(cherry picked from commit d9d956d)
Signed-off-by: Tyler Ohlsen <[email protected]>

Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit 06d53fb)
* Add 2.3 release notes

Signed-off-by: Tyler Ohlsen <[email protected]>

* Add other documentation PR

Signed-off-by: Tyler Ohlsen <[email protected]>

Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit 19a6c84)
opensearch-trigger-bot bot and others added 13 commits January 25, 2024 09:49
…h-project#1144)

* Remove default admin credentials



* Replace default password with a placeholder in README files



---------


(cherry picked from commit 7192d84)

Signed-off-by: Jackie Han <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…opensearch-project#1136)

(cherry picked from commit 97482c1)

Signed-off-by: Jackie Han <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ject#1147)

(cherry picked from commit 475f0c3)

Signed-off-by: owaiskazi19 <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ensearch-project#1103)

* Fix build, update CVE-affected versions

* Spotless depends on CVE-impacted eclipse dependency, now needs JDK17+



---------

Signed-off-by: Daniel Widdis <[email protected]>
…local issue when running this script (opensearch-project#1121) (opensearch-project#1127)

(cherry picked from commit e5cbe93)

Signed-off-by: zane-neo <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…oject#1076) (opensearch-project#1084)

Bumps [aws-actions/configure-aws-credentials](https://github.com/aws-actions/configure-aws-credentials) from 1.7.0 to 4.0.1.
- [Release notes](https://github.com/aws-actions/configure-aws-credentials/releases)
- [Changelog](https://github.com/aws-actions/configure-aws-credentials/blob/main/CHANGELOG.md)
- [Commits](aws-actions/configure-aws-credentials@v1.7.0...v4.0.1)

---
updated-dependencies:
- dependency-name: aws-actions/configure-aws-credentials
  dependency-type: direct:production
  update-type: version-update:semver-major
...



(cherry picked from commit dd9c152)

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…1153)

(cherry picked from commit 290bdcd)

Signed-off-by: Kaituo Li <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
) (opensearch-project#1165)

(cherry picked from commit 1507dd4)

Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: opensearch-ci-bot <[email protected]>
Co-authored-by: opensearch-ci-bot <[email protected]>
(cherry picked from commit 5b85720)

Signed-off-by: owaiskazi19 <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ct#1171)

(cherry picked from commit 303ceb5)

Signed-off-by: Joshua Palis <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Joshua Palis <[email protected]>
@opensearch-trigger-bot opensearch-trigger-bot bot added documentation Improvements or additions to documentation infra Changes to infrastructure, testing, CI/CD, pipelines, etc. backport 2.x labels Mar 25, 2024
@joshpalis joshpalis closed this Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x documentation Improvements or additions to documentation infra Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.