-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Enable Flattened custom result index checkbox #830
Merged
jackiehanyang
merged 2 commits into
opensearch-project:main
from
jackiehanyang:flattenCustomResultIndex
Aug 7, 2024
Merged
Add Enable Flattened custom result index checkbox #830
jackiehanyang
merged 2 commits into
opensearch-project:main
from
jackiehanyang:flattenCustomResultIndex
Aug 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jackie Han <[email protected]>
jackiehanyang
requested review from
ohltyler,
kaituo,
amitgalitz,
sean-zheng-amazon,
dbwiddis,
owaiskazi19 and
joshpalis
as code owners
August 5, 2024 23:56
Signed-off-by: Jackie Han <[email protected]>
Looks good. Wait for CI to pass. |
2 tests that are not related to my change failed for my previous commit because of this error:
They might fail again in the current run. Will monitoring it |
UT CI failed due to same unrelated issue. Working with OSD team about this issue...
|
kaituo
approved these changes
Aug 7, 2024
tracking the failing ut issue here - #832 |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 7, 2024
* Add Enable Flattened custom result index checkbox Signed-off-by: Jackie Han <[email protected]> * add hint text Signed-off-by: Jackie Han <[email protected]> --------- Signed-off-by: Jackie Han <[email protected]> (cherry picked from commit d220c73)
jackiehanyang
added a commit
that referenced
this pull request
Aug 7, 2024
* Add Enable Flattened custom result index checkbox Signed-off-by: Jackie Han <[email protected]> * add hint text Signed-off-by: Jackie Han <[email protected]> --------- Signed-off-by: Jackie Han <[email protected]> (cherry picked from commit d220c73) Co-authored-by: Jackie Han <[email protected]>
jackiehanyang
added a commit
to jackiehanyang/anomaly-detection-dashboards-plugin
that referenced
this pull request
Sep 3, 2024
jackiehanyang
added a commit
to jackiehanyang/anomaly-detection-dashboards-plugin
that referenced
this pull request
Sep 3, 2024
jackiehanyang
added a commit
that referenced
this pull request
Sep 3, 2024
…" (#862) * Revert "Add Enable Flattened custom result index checkbox (#830) (#833)" This reverts commit f53450c. * update snapshot Signed-off-by: Jackie Han <[email protected]> --------- Signed-off-by: Jackie Han <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Enable Flattened custom result index checkbox to allow customer to enable this feature
Screen.Recording.2024-08-05.at.15.49.35.mov
Issues Resolved
opensearch-project/anomaly-detection#1213
Check List
--signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.