Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add paths to _cluster/stats API for metric filtering. #16425

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SwethaGuptha
Copy link
Contributor

@SwethaGuptha SwethaGuptha commented Oct 22, 2024

Description

Add rest API specs for new URI paths added to _cluster/stats API for metric filtering in #15938.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❕ Gradle check result for e29169a: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.95%. Comparing base (ad7f9e7) to head (e29169a).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16425      +/-   ##
============================================
- Coverage     72.05%   71.95%   -0.11%     
+ Complexity    64861    64789      -72     
============================================
  Files          5309     5309              
  Lines        302734   302785      +51     
  Branches      43733    43750      +17     
============================================
- Hits         218134   217854     -280     
- Misses        66731    67044     +313     
- Partials      17869    17887      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does this need a documentation change?

@SwethaGuptha
Copy link
Contributor Author

LGTM. Does this need a documentation change?

Documentation change PR has been raised: opensearch-project/documentation-website#8595

@SwethaGuptha
Copy link
Contributor Author

@dbwiddis can you help in closing this review if there are no other concerns?

@dbwiddis
Copy link
Member

@dbwiddis can you help in closing this review if there are no other concerns?

Please complete the checklist in the PR template.

  1. Needs a change log entry before I can do anything with it. I assume this is targeted to 2.x as well?
  2. Should there also be a corresponding change to the REST API spec here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants