Fix search_as_you_type not supporting multi-fields #15988
Conversation
Signed-off-by: Gao Binlong <[email protected]>
gaobinlong
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
Signed-off-by: Gao Binlong <[email protected]>
|
❌ Gradle check result for 46195e5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 087bf27: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Gao Binlong <[email protected]>
|
❌ Gradle check result for 605d96d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15988 +/- ##
============================================
- Coverage 71.96% 71.86% -0.10%
+ Complexity 64391 64301 -90
============================================
Files 5280 5280
Lines 300866 300873 +7
Branches 43474 43474
============================================
- Hits 216510 216221 -289
- Misses 66639 66918 +279
- Partials 17717 17734 +17 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Gao Binlong <[email protected]>
gaobinlong
force-pushed
the
fix_search_as_you_type
branch
from
fa76419
to
b98cda7
Compare
|
❕ Gradle check result for b98cda7: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Signed-off-by: Gao Binlong <[email protected]>
|
❌ Gradle check result for c4c8fb1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for c4c8fb1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Description
Now
search_as_you_typeignores thefieldsparameter specified in the mapping, the reason is thatSearchAsYouTypeFieldMapperdoesn't resolve that parameter, this PR fixes the bug.Related Issues
#5035
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.