Implement WithFieldName interface in ValuesSourceAggregationBuilder & FieldSortBuilder #15916
Conversation
dzane17
force-pushed
the
with-field-name
branch
from
89f2845
to
95fff6b
Compare
|
❌ Gradle check result for 89f2845: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❕ Gradle check result for 95fff6b: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15916 +/- ##
============================================
- Coverage 71.93% 71.87% -0.06%
+ Complexity 64374 64305 -69
============================================
Files 5277 5277
Lines 300828 300830 +2
Branches 43474 43474
============================================
- Hits 216411 216233 -178
- Misses 66725 66834 +109
- Partials 17692 17763 +71 ☔ View full report in Codecov by Sentry. |
dzane17
force-pushed
the
with-field-name
branch
from
95fff6b
to
57dbbd0
Compare
dzane17
changed the title
dzane17
force-pushed
the
with-field-name
branch
from
57dbbd0
to
090247f
Compare
|
❕ Gradle check result for 57dbbd0: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
|
❌ Gradle check result for 090247f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
jainankitk
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli and
shwetathareja
as code owners
… FieldSortBuilder Signed-off-by: David Zane <[email protected]>
dzane17
force-pushed
the
with-field-name
branch
from
090247f
to
ca04f8c
Compare
|
@jainankitk done |
|
❌ Gradle check result for ca04f8c: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for ca04f8c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Unrelated flaky test: |
|
Related to #15953 |
|
❌ Gradle check result for ca04f8c: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
More flaky tests: |
|
Related to #14310 |
|
Related to #14407 |
|
❌ Gradle check result for ca04f8c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Seems the failing tests were fixed as part of #15859: @dzane17 - Can you merge from latest |
|
❌ Gradle check result for ca04f8c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
@jainankitk The branch is up to date including that flaky test PR 15859 |
|
❕ Gradle check result for ca04f8c: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15916-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7c427d9fd588597343654d2f534952f7116d1df4
# Push it to GitHub
git push --set-upstream origin backport/backport-15916-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.xThen, create a pull request where the |
… FieldSortBuilder (opensearch-project#15916) Signed-off-by: David Zane <[email protected]> (cherry picked from commit 7c427d9)
… FieldSortBuilder (opensearch-project#15916) Signed-off-by: David Zane <[email protected]> (cherry picked from commit 7c427d9)
… FieldSortBuilder (opensearch-project#15916) Signed-off-by: David Zane <[email protected]>
… FieldSortBuilder (opensearch-project#15916) Signed-off-by: David Zane <[email protected]> (cherry picked from commit 7c427d9)
… FieldSortBuilder (#15916) (#15970) Signed-off-by: David Zane <[email protected]> (cherry picked from commit 7c427d9)
Description
Implement WithFieldName interface in ValuesSourceAggregationBuilder & FieldSortBuilder
This is a continuation of #15705
Related Issues
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.