Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Add cluster state checksum in manifest #15218 #15612

Merged
merged 8 commits into from
Sep 4, 2024

Conversation

himshikha
Copy link
Contributor

@himshikha himshikha commented Sep 3, 2024

Description

Backport of #15218

Related Issues

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

himshikha and others added 2 commits September 3, 2024 17:58
* Add cluster state checksum in manifest for remote state and routing table publication

Signed-off-by: Himshikha Gupta <[email protected]>
Co-authored-by: Bukhtawar Khan <[email protected]>
Signed-off-by: Himshikha Gupta <[email protected]>
Copy link
Contributor

github-actions bot commented Sep 3, 2024

❌ Gradle check result for cc930c0: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Himshikha Gupta <[email protected]>
Copy link
Contributor

github-actions bot commented Sep 3, 2024

✅ Gradle check result for f30fd4d: SUCCESS

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 74.46809% with 132 lines in your changes missing coverage. Please review.

Project coverage is 71.70%. Comparing base (5875393) to head (7c79a8a).
Report is 7 commits behind head on 2.x.

Files with missing lines Patch % Lines
...arch/gateway/remote/RemoteClusterStateService.java 33.33% 54 Missing and 10 partials ⚠️
...main/java/org/opensearch/cluster/ClusterState.java 4.00% 24 Missing ⚠️
...pensearch/gateway/remote/ClusterStateChecksum.java 94.36% 6 Missing and 6 partials ⚠️
...h/index/translog/BufferedChecksumStreamOutput.java 72.09% 12 Missing ⚠️
...va/org/opensearch/cluster/node/DiscoveryNodes.java 58.33% 1 Missing and 9 partials ⚠️
...search/gateway/remote/ClusterMetadataManifest.java 85.18% 1 Missing and 3 partials ⚠️
...search/cluster/routing/IndexShardRoutingTable.java 82.35% 3 Missing ⚠️
.../java/org/opensearch/cluster/AbstractDiffable.java 0.00% 1 Missing ⚠️
...org/opensearch/cluster/metadata/IndexMetadata.java 94.73% 0 Missing and 1 partial ⚠️
...opensearch/cluster/metadata/TemplatesMetadata.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##                2.x   #15612    +/-   ##
==========================================
  Coverage     71.70%   71.70%            
- Complexity    64104    64227   +123     
==========================================
  Files          5249     5251     +2     
  Lines        299681   300426   +745     
  Branches      43643    43716    +73     
==========================================
+ Hits         214876   215414   +538     
- Misses        66848    66974   +126     
- Partials      17957    18038    +81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Sep 3, 2024

❌ Gradle check result for 0978f7b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@himshikha
Copy link
Contributor Author

❌ Gradle check result for 0978f7b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Flaky test #14599

Copy link
Contributor

github-actions bot commented Sep 3, 2024

✅ Gradle check result for 9421646: SUCCESS

Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 87e5b32: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 4, 2024

❕ Gradle check result for cf7119b: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 7c79a8a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 4, 2024

✅ Gradle check result for 7c79a8a: SUCCESS

@Bukhtawar Bukhtawar merged commit b408ef8 into opensearch-project:2.x Sep 4, 2024
37 of 38 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/backport-2.17
# Create a new branch
git switch --create backport/backport-15612-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b408ef8596afb2d7fb0b4cbea8abfd9f84ca5445
# Push it to GitHub
git push --set-upstream origin backport/backport-15612-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport/backport-15612-to-2.17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants