-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flat object field use IndexOrDocValuesQuery to optimize query #14383
base: main
Are you sure you want to change the base?
Flat object field use IndexOrDocValuesQuery to optimize query #14383
Conversation
server/src/test/java/org/opensearch/index/mapper/FlatObjectFieldTypeTests.java
Show resolved
Hide resolved
❌ Gradle check result for 9da1d18: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
9da1d18
to
48b7f47
Compare
After #13853 is merged, the pr can be merged later. |
❌ Gradle check result for 48b7f47: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@kkewwei looks like a bunch of |
e53defb
to
e9fe867
Compare
❌ Gradle check result for e53defb: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for e9fe867: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
e9fe867
to
428c93e
Compare
❌ Gradle check result for 428c93e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
I'm more concerned about the number of tokens produced by value side of things. Suppose we have a dot-path like the following:
If we want to support full-text search on that field, using StandardAnalyzer, I think we would translate For that to work, at indexing time, we would run the analyzer on the value, and write the following tokens to
Essentially, every token for every path needs to be added. It can work (and it definitely did work when I did it 11 years ago), but we might need to be careful. Anyway, I'll write up a proposal for adding analyzer support to flat object fields. I can dig up some details from that old project. Also, thanks for bringing up #13853! I'll take a look at that one soon! |
428c93e
to
c04f6be
Compare
❌ Gradle check result for c04f6be: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
c04f6be
to
2840b3a
Compare
❌ Gradle check result for 2840b3a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
2840b3a
to
88ca24f
Compare
88ca24f
to
3d1ed2a
Compare
❌ Gradle check result for 3d1ed2a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
3d1ed2a
to
88ca24f
Compare
❌ Gradle check result for 88ca24f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 6825b2e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
f771a6e
to
74e096a
Compare
❌ Gradle check result for 74e096a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: kkewwei <[email protected]>
74e096a
to
d9046ad
Compare
❕ Gradle check result for d9046ad: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Description
The pr mainly support the two features:
1.flat object field use IndexOrDocValuesQuery to optimize query.
2.flat object field delegate to keyword field to reduce code duplication.
Related Issues
Resolves #11635 #11537
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.