Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flakiness of testRemoteCleanupDeleteStale, bug fix in RemoteMetadataManifest and RemoteReadResult #14230

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Fix flakiness of testRemoteCleanupDeleteStale, bug fix in RemoteMetadataManifest and RemoteReadResult #14230

merged 3 commits into from
Jun 14, 2024

Conversation

shiv0408
Copy link
Member

@shiv0408 shiv0408 commented Jun 12, 2024 •
edited
Loading

Description

We see that Cleanup interval setting set before the might not be applied before the interval for assert is over.
Added a check to ensure that setting is updated before checking if files are deleted.

Further, addressing some bugs found after merging #14089

Ran the test 1000 times to ensure that flakiness is not there now.

Related Issues

Resolves #14205
Resolves #13968

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added >test-failure Test failure from CI, local build, etc. autocut bug Something isn't working labels Jun 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for a8bf4b0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for f5831ac: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 376eb8c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@prudhvigodithi
Copy link
Contributor

From this AUTOCUT issue #14315 (comment) I can see the testEndToEndRemoteMigration has failed on some other PR's and post merge actions.

@shiv0408
Add unit test
af9c6be 
Signed-off-by: Shivansh Arora <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for af9c6be: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shiv0408
Copy link
Member Author

❌ Gradle check result for af9c6be: FAILURE

org.opensearch.cache.common.tier.TieredSpilloverCacheStatsIT.testIndicesAndTierLevelAggregation - #14281

@shwetathareja shwetathareja added backport 2.x Backport to 2.x branch backport 2.15 labels Jun 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for af9c6be: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shwetathareja
Copy link
Member

❌ Gradle check result for af9c6be: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock
org.opensearch.index.IndexServiceTests.testAsyncTranslogTrimTaskOnClosedIndex

@shiv0408
Copy link
Member Author

org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock - #10006
org.opensearch.index.IndexServiceTests.testAsyncTranslogTrimTaskOnClosedIndex - #11547

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for af9c6be: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for af9c6be: SUCCESS

@shwetathareja shwetathareja merged commit 0c2ff03 into opensearch-project:main Jun 14, 2024
37 checks passed
@shiv0408 shiv0408 deleted the fix_14205 branch June 14, 2024 14:04
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 14, 2024
@github-actions
Fix flakiness of testRemoteCleanupDeleteStale, bug fix in RemoteMetad…
9cb6749 
…ataManifest and RemoteReadResult (#14230)

* Address flakiness of testRemoteCleanupDeleteStale
- Make RemoteReadResult have Object rather than ToXContent
- Fix getManifestCodecVersion in RemoteClusterMetadataManifest

Signed-off-by: Shivansh Arora <[email protected]>
(cherry picked from commit 0c2ff03)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jun 14, 2024
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 14, 2024
@github-actions
Fix flakiness of testRemoteCleanupDeleteStale, bug fix in RemoteMetad…
ab91351 
…ataManifest and RemoteReadResult (#14230)

* Address flakiness of testRemoteCleanupDeleteStale
- Make RemoteReadResult have Object rather than ToXContent
- Fix getManifestCodecVersion in RemoteClusterMetadataManifest

Signed-off-by: Shivansh Arora <[email protected]>
(cherry picked from commit 0c2ff03)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jun 14, 2024
Merged
gbbafna pushed a commit that referenced this pull request Jun 14, 2024
@opensearch-trigger-bot @github-actions
Fix flakiness of testRemoteCleanupDeleteStale, bug fix in RemoteMetad…
506f4b1 
…ataManifest and RemoteReadResult (#14230) (#14354)


(cherry picked from commit 0c2ff03)

Signed-off-by: Shivansh Arora <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@finnegancarroll finnegancarroll mentioned this pull request Jun 14, 2024
Merged
3 tasks
This was referenced Jun 13, 2024
Open
Open
@prudhvigodithi prudhvigodithi mentioned this pull request Jun 14, 2024
Closed
shwetathareja pushed a commit that referenced this pull request Jun 15, 2024
@opensearch-trigger-bot @github-actions
Fix flakiness of testRemoteCleanupDeleteStale, bug fix in RemoteMetad…
1416f20 
…ataManifest and RemoteReadResult (#14230) (#14353)

* Address flakiness of testRemoteCleanupDeleteStale
- Make RemoteReadResult have Object rather than ToXContent
- Fix getManifestCodecVersion in RemoteClusterMetadataManifest


(cherry picked from commit 0c2ff03)

Signed-off-by: Shivansh Arora <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@shiv0408 shiv0408 mentioned this pull request Jun 17, 2024
Open
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Jun 17, 2024
Open
harshavamsi pushed a commit to harshavamsi/OpenSearch that referenced this pull request Jul 12, 2024
@shiv0408 @harshavamsi
Fix flakiness of testRemoteCleanupDeleteStale, bug fix in RemoteMetad…
714c741 
…ataManifest and RemoteReadResult (opensearch-project#14230)

* Address flakiness of testRemoteCleanupDeleteStale
- Make RemoteReadResult have Object rather than ToXContent
- Fix getManifestCodecVersion in RemoteClusterMetadataManifest

Signed-off-by: Shivansh Arora <[email protected]>
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
@opensearch-trigger-bot @github-actions @kkewwei
Fix flakiness of testRemoteCleanupDeleteStale, bug fix in RemoteMetad…
a6790cb 
…ataManifest and RemoteReadResult (opensearch-project#14230) (opensearch-project#14353)

* Address flakiness of testRemoteCleanupDeleteStale
- Make RemoteReadResult have Object rather than ToXContent
- Fix getManifestCodecVersion in RemoteClusterMetadataManifest

(cherry picked from commit 0c2ff03)

Signed-off-by: Shivansh Arora <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: kkewwei <[email protected]>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
@shiv0408
Fix flakiness of testRemoteCleanupDeleteStale, bug fix in RemoteMetad…
7079277 
…ataManifest and RemoteReadResult (opensearch-project#14230)

* Address flakiness of testRemoteCleanupDeleteStale
- Make RemoteReadResult have Object rather than ToXContent
- Fix getManifestCodecVersion in RemoteClusterMetadataManifest

Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soosinha soosinha soosinha approved these changes

@shwetathareja shwetathareja shwetathareja approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
autocut backport 2.x Backport to 2.x branch backport 2.15 bug Something isn't working ClusterManager:RemoteState flaky-test Random test failure that succeeds on second run >test-failure Test failure from CI, local build, etc.
Projects
Storage Project Board
Status: ✅ Done
Milestone
No milestone
6 participants
@shiv0408 @shwetathareja @andrross @prudhvigodithi @soosinha @shourya035