Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Autocomplete] PPL table name parser fix #8843

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

paulstn
Copy link
Contributor

@paulstn paulstn commented Nov 11, 2024

Description

Every file under .generated can be ignored

There were two changes made.

  • The first one was to the PPL grammar file, reverting back a fix to prevent the table name being suggested twice and ultimately preventing any further suggestions from appearing.
  • The second change was in the opensearch_ppl_autocomplete.ts file, doing the fix the first change handled by instead intercepting a deeper rule in the grammar, preventing the table from incorrectly being suggested. The code completion engine was hitting the first table rule twice, possibly due to an option where the lexer rule allows for whitespace.

Ultimately, this helps to solve an issue where correctly formatted table names (with backticks, etc.) prevented other suggestions from appearing. The original grammar would've parsed it correctly.

Issues Resolved

Screenshot

Testing the changes

Changelog

  • fix: PPL table name parser

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@joshuali925
Copy link
Member

there are some issues with CI right now

@joshuali925 joshuali925 merged commit 0f899df into opensearch-project:main Nov 12, 2024
58 of 59 checks passed
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@paulstn paulstn deleted the original-ppl-gramma branch November 12, 2024 01:09
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 12, 2024
Signed-off-by: Paul Sebastian <[email protected]>
(cherry picked from commit 0f899df)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.85%. Comparing base (995d986) to head (6d96663).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8843      +/-   ##
==========================================
- Coverage   60.87%   60.85%   -0.02%     
==========================================
  Files        3799     3799              
  Lines       90762    90783      +21     
  Branches    14292    14294       +2     
==========================================
+ Hits        55247    55249       +2     
- Misses      32005    32025      +20     
+ Partials     3510     3509       -1     
Flag Coverage Δ
Linux_1 29.04% <ø> (-0.01%) ⬇️
Linux_2 56.39% <ø> (ø)
Linux_3 37.79% <ø> (-0.02%) ⬇️
Linux_4 29.86% <ø> (-0.02%) ⬇️
Windows_1 29.05% <ø> (-0.01%) ⬇️
Windows_2 56.34% <ø> (ø)
Windows_3 37.79% <ø> (-0.02%) ⬇️
Windows_4 29.86% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

abbyhu2000 pushed a commit that referenced this pull request Nov 12, 2024
(cherry picked from commit 0f899df)

Signed-off-by: Paul Sebastian <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants